[keyserver][lib] Restrict updateRoles endpoint to ThinThreadType
ClosedPublic
Actions

Authored by ashoat on Aug 13 2024, 12:51 PM.

Details

Reviewers

tomek
inka

Commits

rCOMM9499881e4603: [keyserver][lib] Restrict updateRoles endpoint to ThinThreadType

Summary

Keyserver endpoints don't need to concern themselves with thick threads. I don't think we're using ThreadChanges for thick threads currently.

Depends on D13073

Test Plan

Flow, and reading through the code

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Aug 13 2024, 12:51 PM

ashoat added a child revision: D13075: [keyserver] Prevent updateRoles from resetting user-surfaced permissions.

Harbormaster completed remote builds in B31083: Diff 43369.Aug 13 2024, 1:08 PM

ashoat requested review of this revision.Aug 13 2024, 1:08 PM

I don't think we're using ThreadChanges for thick threads currently.

There was an iteration of changeThreadSettingsSpec where it was used, but we no longer use it.

This revision is now accepted and ready to land.Aug 14 2024, 8:40 AM

Closed by commit rCOMM9499881e4603: [keyserver][lib] Restrict updateRoles endpoint to ThinThreadType (authored by ashoat). · Explain WhyAug 14 2024, 9:50 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9499881e4603: [keyserver][lib] Restrict updateRoles endpoint to ThinThreadType.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

role-updaters.js

4 lines

lib/

types/

thread-types.js

3 lines

Diff 43399

View Options

keyserver/src/updaters/role-updaters.js