Page MenuHomePhabricator

[native] Fix broken StyleProps type for react-native-reanimated libdef
ClosedPublic

Authored by ashoat on Aug 20 2024, 9:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 6:27 AM
Unknown Object (File)
Mar 4 2025, 9:25 PM
Unknown Object (File)
Feb 19 2025, 3:36 AM
Unknown Object (File)
Feb 17 2025, 1:49 PM
Unknown Object (File)
Feb 17 2025, 1:49 PM
Unknown Object (File)
Feb 17 2025, 1:48 PM
Unknown Object (File)
Feb 6 2025, 10:30 AM
Unknown Object (File)
Jan 27 2025, 9:00 AM
Subscribers
None

Details

Summary

This issue was first introduced in D5556, and led to a $FlowFixMe being introduced in D13066.

It's not possible to spread a non-object. I remove the spreads here because the only relevant part of the union is the object form ({ [name: string]: any, ... }), which is already included in the StyleProps type anyways.

This diff addresses part of ENG-9039.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable