Page MenuHomePhabricator

[native] introduced flow type for reanimated layout animations
ClosedPublic

Authored by ginsu on Nov 8 2022, 8:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 10:51 PM
Unknown Object (File)
Sun, Nov 3, 10:50 PM
Unknown Object (File)
Sun, Nov 3, 10:50 PM
Unknown Object (File)
Sun, Nov 3, 10:49 PM
Unknown Object (File)
Sun, Nov 3, 10:42 PM
Unknown Object (File)
Sun, Nov 3, 10:33 PM
Unknown Object (File)
Sun, Nov 3, 1:57 AM
Unknown Object (File)
Sun, Nov 3, 1:57 AM

Details

Summary

To use Reanimated's new layout animations we need to add libdefs for the different animations. This diff just handles the SlideInDown and SlideOutDown layout animations along with all the necessary classes/types needed to support these layout animations. I will annotate inline with where the changes/types came from.


Linear Task: ENG-2165

Test Plan

All the testing for this diff came from its use in D5557. In that diff I was able to implement the layout actions using the appropriate type defs that I created in this diff, and I received no flow errors which I believe to be a good indicator that everything is correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu requested review of this revision.Nov 8 2022, 8:32 AM
ginsu planned changes to this revision.Nov 8 2022, 8:34 AM
ginsu added inline comments.
native/flow-typed/npm/react-native-reanimated_v2.x.x.js
18–36 ↗(On Diff #18211)
146 ↗(On Diff #18211)
ginsu edited the test plan for this revision. (Show Details)

made LayoutAnimation type exact

ashoat added 1 blocking reviewer(s): atul.

Looks good to me, would love if @atul could take a look as well

ginsu planned changes to this revision.Nov 8 2022, 8:38 AM

need to fix prettier format change

resoved prettier problem

This revision is now accepted and ready to land.Nov 8 2022, 11:19 AM