Page MenuHomePhabricator
Differential D5556

[native] introduced flow type for reanimated layout animations
ClosedPublic
Actions

Authored by ginsu on Nov 8 2022, 8:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 10:51 PM
Unknown Object (File)
Sun, Nov 3, 10:50 PM
Unknown Object (File)
Sun, Nov 3, 10:50 PM
Unknown Object (File)
Sun, Nov 3, 10:49 PM
Unknown Object (File)
Sun, Nov 3, 10:42 PM
Unknown Object (File)
Sun, Nov 3, 10:33 PM
Unknown Object (File)
Sun, Nov 3, 1:57 AM
Unknown Object (File)
Sun, Nov 3, 1:57 AM
View All Files
Subscribers
• abosh
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM032ab74877db: [native] introduced flow type for reanimated layout animations
Summary

To use Reanimated's new layout animations we need to add libdefs for the different animations. This diff just handles the SlideInDown and SlideOutDown layout animations along with all the necessary classes/types needed to support these layout animations. I will annotate inline with where the changes/types came from.

Linear Task: ENG-2165

Test Plan

All the testing for this diff came from its use in D5557. In that diff I was able to implement the layout actions using the appropriate type defs that I created in this diff, and I received no flow errors which I believe to be a good indicator that everything is correct.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Nov 8 2022, 8:22 AM
Herald added subscribers: • abosh, atul, tomek, ashoat. · View Herald TranscriptNov 8 2022, 8:22 AM
ginsu edited the summary of this revision. (Show Details)Nov 8 2022, 8:29 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
Harbormaster completed remote builds in B13269: Diff 18211.Nov 8 2022, 8:32 AM
ginsu requested review of this revision.Nov 8 2022, 8:32 AM
ginsu planned changes to this revision.Nov 8 2022, 8:34 AM
ginsu added inline comments.
native/flow-typed/npm/react-native-reanimated_v2.x.x.js
18–36 ↗(On Diff #18211)

bottom-tabs_v6

146 ↗(On Diff #18211)

reanimated easing

ginsu updated this revision to Diff 18215.Nov 8 2022, 8:37 AM
ginsu edited the test plan for this revision. (Show Details)

made LayoutAnimation type exact

ashoat accepted this revision.Nov 8 2022, 8:37 AM
ashoat added 1 blocking reviewer(s): atul.

Looks good to me, would love if @atul could take a look as well

ginsu planned changes to this revision.Nov 8 2022, 8:38 AM

need to fix prettier format change

ginsu updated this revision to Diff 18216.Nov 8 2022, 8:41 AM

resoved prettier problem

Harbormaster completed remote builds in B13273: Diff 18215.Nov 8 2022, 8:50 AM
Harbormaster completed remote builds in B13274: Diff 18216.Nov 8 2022, 8:54 AM
ginsu added inline comments.Nov 8 2022, 9:35 AM
native/flow-typed/npm/react-native-reanimated_v2.x.x.js
18–36

bottom-tabs_v6

146

reanimated easing

237–312

reanimated common types

314–336

reanimated BaseAnimationBuilder

342–382

reanimated ComplexAnimationBuilder

384–388

reanimated slideindown

390–394

reanimated slideoutdown

ginsu added a child revision: D5557: [native] changed tooltip animation to slide up/down on enter and exit.Nov 8 2022, 9:47 AM
atul accepted this revision.Nov 8 2022, 11:19 AM

Looks good to me

This revision is now accepted and ready to land.Nov 8 2022, 11:19 AM
Closed by commit rCOMM032ab74877db: [native] introduced flow type for reanimated layout animations (authored by ginsu). · Explain WhyNov 8 2022, 11:46 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM032ab74877db: [native] introduced flow type for reanimated layout animations.
ashoat mentioned this in D13124: [native] Fix broken StyleProps type for react-native-reanimated libdef.Aug 20 2024, 9:58 AM
ashoat mentioned this in rCOMMfc35683c9ffa: [native] Fix broken StyleProps type for react-native-reanimated libdef.Aug 20 2024, 11:49 PM

Revision Contents
Changeset List

PathSize
native/
flow-typed/
npm/
180 lines

Diff 18216

View Options

native/flow-typed/npm/react-native-reanimated_v2.x.x.js

Loading...