Paths

Table of Contentst

Differential D13204

[lib] improve `processOutboundP2PMessages` in terms of performance
ClosedPublic
Actions

Authored by kamil on Aug 28 2024, 10:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 6, 11:03 PM

	Unknown Object (File)
	Oct 6 2024, 9:03 PM

	Unknown Object (File)
	Oct 6 2024, 9:03 PM

	Unknown Object (File)
	Oct 6 2024, 9:03 PM

	Unknown Object (File)
	Oct 6 2024, 9:02 PM

	Unknown Object (File)
	Oct 6 2024, 7:43 PM

	Unknown Object (File)
	Oct 1 2024, 3:40 AM

	Unknown Object (File)
	Oct 1 2024, 3:40 AM

View All 40 Files

Subscribers

Details

Reviewers

tomek
marcin

Commits

rCOMM65803b806732: [lib] improve `processOutboundP2PMessages` in terms of performance

Summary

We need to do it per device, not per message to avoid creating multiple sessions in parallel.

Test Plan

Test DM ops (text messages, settings, reactions, etc.)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Aug 28 2024, 10:22 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 28 2024, 10:22 AM

kamil published this revision for review.Aug 28 2024, 10:22 AM

kamil edited the summary of this revision. (Show Details)

tomek accepted this revision.Aug 28 2024, 10:26 AM

tomek added inline comments.

lib/tunnelbroker/peer-to-peer-context.js
131–133 ↗	(On Diff #43775)	It might look a little better as a map instead of a for.

This revision is now accepted and ready to land.Aug 28 2024, 10:26 AM

Harbormaster completed remote builds in B31355: Diff 43775.Aug 28 2024, 10:39 AM

use map

Harbormaster completed remote builds in B31361: Diff 43781.Aug 29 2024, 12:57 AM

Closed by commit rCOMM65803b806732: [lib] improve `processOutboundP2PMessages` in terms of performance (authored by kamil). · Explain WhyAug 29 2024, 1:16 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM65803b806732: [lib] improve `processOutboundP2PMessages` in terms of performance.

ashoat added inline comments.Sep 6 2024, 11:57 AM

lib/tunnelbroker/peer-to-peer-context.js
134	Why do we still go through each message one-by-one, instead of in parallel?

ashoat added inline comments.Sep 10 2024, 8:06 AM

lib/tunnelbroker/peer-to-peer-context.js
134	Discussed this with @kamil in our 1:1 today. The reason for this is that if we're sending multiple messages to the same device, we would end up initiating the session multiple times, which would be very bad as we'd override the session. We'll track improving this in ENG-9106

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-context.js

74 lines

Diff 43789

lib/tunnelbroker/peer-to-peer-context.js

Loading...