[lib] add Tunnelbroker request timeout
ClosedPublic
Actions

Authored by kamil on Sep 6 2024, 4:26 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 1:53 PM

	Unknown Object (File)
	Sun, Nov 10, 11:47 AM

	Unknown Object (File)
	Sun, Nov 10, 7:44 AM

	Unknown Object (File)
	Sun, Nov 10, 3:08 AM

	Unknown Object (File)
	Sat, Nov 9, 8:22 AM

	Unknown Object (File)
	Sat, Nov 9, 8:15 AM

	Unknown Object (File)
	Oct 10 2024, 1:10 PM

	Unknown Object (File)
	Oct 10 2024, 1:10 PM

View All 33 Files

Subscribers

ashoat

Details

Reviewers

tomek
bartek

Commits

rCOMM4154d1237b68: [lib] add Tunnelbroker request timeout

Summary

ENG-9105.

Adding timeout to reject promise, this is similar timeout approach to other places in our codebase.

Test Plan

Simulate hanging Tunnelbroker request and check that promise is rejected on the client.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 6 2024, 4:26 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 6 2024, 4:26 AM

Harbormaster completed remote builds in B31447: Diff 43912.Sep 6 2024, 4:47 AM

kamil published this revision for review.Sep 6 2024, 5:37 AM

tomek accepted this revision.Sep 6 2024, 7:48 AM

This revision is now accepted and ready to land.Sep 6 2024, 7:48 AM

Closed by commit rCOMM4154d1237b68: [lib] add Tunnelbroker request timeout (authored by kamil). · Explain WhySep 10 2024, 5:51 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4154d1237b68: [lib] add Tunnelbroker request timeout.

Revision Contents
Changeset List

Path

Size

lib/

shared/

timeouts.js

3 lines

tunnelbroker/

tunnelbroker-context.js

15 lines

Diff 44006

View Options

lib/shared/timeouts.js