Page MenuHomePhabricator
Differential D13256

Extend pending thread IDs to support thick sidebars
ClosedPublic
Actions

Authored by marcin on Sep 6 2024, 5:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 5:03 PM
Unknown Object (File)
Wed, Dec 18, 5:03 PM
Unknown Object (File)
Wed, Dec 18, 5:03 PM
Unknown Object (File)
Wed, Dec 18, 5:00 PM
Unknown Object (File)
Thu, Nov 28, 9:18 PM
Unknown Object (File)
Nov 22 2024, 12:53 AM
Unknown Object (File)
Nov 9 2024, 10:32 PM
Unknown Object (File)
Nov 9 2024, 4:21 PM
View All 35 Files
Subscribers
ashoat

Details

Reviewers
tomek
inka
Commits
rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars
Summary

This differential extends pending thread IDs to support thick sidebars.

Test Plan

jest

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin created this revision.Sep 6 2024, 5:28 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 6 2024, 5:28 AM
Harbormaster completed remote builds in B31454: Diff 43919.Sep 6 2024, 5:55 AM
marcin requested review of this revision.Sep 6 2024, 5:55 AM
inka accepted this revision.Sep 6 2024, 6:07 AM
This revision is now accepted and ready to land.Sep 6 2024, 6:07 AM
Closed by commit rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars (authored by marcin). · Explain WhySep 6 2024, 6:11 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMbbe775f0a586: Extend pending thread IDs to support thick sidebars.
tomek added inline comments.Sep 9 2024, 1:09 AM
lib/shared/thread-utils.js
399

Wondering whether we should expose thick word in the user-facing place, the URL. How about dm_sidebar?

Revision Contents
Changeset List

PathSize
lib/
shared/
32 lines
18 lines
utils/
2 lines

Diff 43923

View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/shared/thread-utils.test.js

Loading...
View Options

lib/utils/validation-utils.js

Loading...