Page MenuHomePhabricator
Differential D13387

[lib] fix useFCNames
ClosedPublic
Actions

Authored by varun on Sep 18 2024, 12:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 10, 10:40 AM
Unknown Object (File)
Sat, Oct 5, 2:49 PM
Unknown Object (File)
Wed, Oct 2, 3:29 AM
Unknown Object (File)
Wed, Oct 2, 2:19 AM
Unknown Object (File)
Sun, Sep 29, 10:25 AM
Unknown Object (File)
Thu, Sep 19, 8:44 PM
Unknown Object (File)
Thu, Sep 19, 8:43 PM
Unknown Object (File)
Thu, Sep 19, 8:43 PM
View All 12 Files
Subscribers
tomek

Details

Reviewers
ashoat
will
Commits
rCOMMa78a969cccfe: [lib] fix useFCNames
Summary

resolves https://linear.app/comm/issue/ENG-9337/fix-broken-usefcnames

Test Plan

https://gist.github.com/vdhanan/9b6a003fb731f7e23fac54e8d594fdef

with patch, i was able to see my farcaster username logged

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Sep 18 2024, 12:56 PM
Herald added a subscriber: tomek. · View Herald TranscriptSep 18 2024, 12:56 PM
varun published this revision for review.Sep 18 2024, 12:56 PM

will make sure CI passes before landing

varun added a reviewer: will. varun removed 1 blocking reviewer(s): ashoat.Sep 18 2024, 12:59 PM
ashoat accepted this revision.Sep 18 2024, 1:05 PM
This revision is now accepted and ready to land.Sep 18 2024, 1:05 PM
Harbormaster completed remote builds in B31705: Diff 44320.Sep 18 2024, 1:17 PM
Closed by commit rCOMMa78a969cccfe: [lib] fix useFCNames (authored by varun). · Explain WhySep 18 2024, 1:19 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMa78a969cccfe: [lib] fix useFCNames.

Revision Contents
Changeset List

PathSize
lib/
hooks/
2 lines

Diff 44321

View Options

lib/hooks/fc-cache.js

Loading...