Page MenuHomePhabricator

[lib] avoid creating `notificationsCreationData` on `DMOperation` received from other peer
ClosedPublic

Authored by kamil on Sep 19 2024, 6:14 AM.
Tags
None
Referenced Files
F3187358: D13388.id44346.diff
Fri, Nov 8, 4:15 PM
Unknown Object (File)
Thu, Nov 7, 8:22 PM
Unknown Object (File)
Thu, Nov 7, 8:18 PM
Unknown Object (File)
Thu, Nov 7, 8:11 PM
Unknown Object (File)
Thu, Nov 7, 8:04 PM
Unknown Object (File)
Thu, Nov 7, 7:56 PM
Unknown Object (File)
Thu, Nov 7, 7:19 PM
Unknown Object (File)
Thu, Nov 7, 6:58 PM
Subscribers

Details

Summary

Looks like we're generating notificationsCreationData even when DMOperation was received, later on this is discarded, but we can avoid generating data that is dropped.

Test Plan
  1. No data generated when DMOperation is received.
  2. Notifs works

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable