Page MenuHomePhabricator
Differential D13396

[keyserver] new fetcher to get all communities
ClosedPublic
Actions

Authored by varun on Thu, Sep 19, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 14, 12:44 PM
Unknown Object (File)
Mon, Oct 14, 12:43 PM
Unknown Object (File)
Mon, Oct 14, 12:43 PM
Unknown Object (File)
Sat, Oct 12, 1:47 AM
Unknown Object (File)
Mon, Oct 7, 1:55 PM
Unknown Object (File)
Thu, Oct 3, 6:32 PM
Unknown Object (File)
Thu, Oct 3, 7:42 AM
Unknown Object (File)
Wed, Oct 2, 2:14 PM
View All 32 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe3c5f6ce1930: [keyserver] new fetcher to get all communities
Summary

we need the community id, name, and farcaster channel id for all communities so we can display them to users in a modal.

part of https://linear.app/comm/issue/ENG-9216/new-keyserver-endpoint-to-get-a-list-of-communities

Test Plan

tested the SQL query directly on my local mariadb instance. will test further in subsequent diffs that call the keyserver endpoint that returns this data

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Thu, Sep 19, 11:37 PM
Harbormaster completed remote builds in B31724: Diff 44354.Thu, Sep 19, 11:54 PM
varun requested review of this revision.Thu, Sep 19, 11:54 PM
varun added a child revision: D13397: [keyserver] new responder function to fetch all community infos with names.Fri, Sep 20, 1:23 AM
ashoat accepted this revision.Fri, Sep 20, 5:41 AM
ashoat added inline comments.
keyserver/src/fetchers/community-fetchers.js
75 ↗(On Diff #44354)

Please keep all lines to a max of 80 chars width

This revision is now accepted and ready to land.Fri, Sep 20, 5:41 AM
varun updated this revision to Diff 44442.Mon, Sep 23, 10:15 AM

fix line length

varun updated this revision to Diff 44444.Mon, Sep 23, 10:20 AM

move type to next diff

Harbormaster completed remote builds in B31780: Diff 44442.Mon, Sep 23, 10:33 AM
Harbormaster completed remote builds in B31782: Diff 44444.Mon, Sep 23, 10:37 AM
Closed by commit rCOMMe3c5f6ce1930: [keyserver] new fetcher to get all communities (authored by varun). · Explain WhyTue, Sep 24, 10:56 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe3c5f6ce1930: [keyserver] new fetcher to get all communities.

Revision Contents
Changeset List

PathSize
keyserver/
src/
fetchers/
32 lines
lib/
types/
5 lines

Diff 44489

View Options

keyserver/src/fetchers/community-fetchers.js

Loading...
View Options

lib/types/community-types.js

Loading...