Page MenuHomePhabricator
Differential D13397

[keyserver] new responder function to fetch all community infos with names
ClosedPublic
Actions

Authored by varun on Sep 20 2024, 1:23 AM.
Tags
None
Referenced Files
F5121366: D13397.id.diff
Thu, Apr 3, 10:38 AM
F5121088: D13397.id44490.diff
Thu, Apr 3, 9:50 AM
F5120140: D13397.id44443.diff
Thu, Apr 3, 6:46 AM
F5118431: D13397.id44355.diff
Thu, Apr 3, 12:45 AM
F5118306: D13397.id44445.diff
Wed, Apr 2, 11:53 PM
Unknown Object (File)
Tue, Apr 1, 10:43 PM
Unknown Object (File)
Tue, Apr 1, 8:59 AM
Unknown Object (File)
Tue, Apr 1, 8:59 AM
View All 70 Files
Subscribers
None

Details

Reviewers
ashoat
tomek
Commits
rCOMMe9076b23f303: [keyserver] new responder function to fetch all community infos with names
Summary

returns an object instead of an array and checks if the viewer is logged in

Depends on D13396

Test Plan

tested at end of stack by calling responder successfullly from web

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Sep 20 2024, 1:23 AM
varun added a child revision: D13398: [lib][keyserver] new endpoint to get all community infos with names.
Harbormaster completed remote builds in B31725: Diff 44355.Sep 20 2024, 1:39 AM
varun requested review of this revision.Sep 20 2024, 1:39 AM
ashoat requested changes to this revision.Sep 20 2024, 5:40 AM
ashoat added inline comments.
keyserver/src/responders/community-responders.js
29 ↗(On Diff #44355)

I don't see this type defined anywhere, either on master or in this stack

This revision now requires changes to proceed.Sep 20 2024, 5:40 AM
varun updated this revision to Diff 44443.Sep 23 2024, 10:17 AM

D13396 contains the missing type in latest revision

varun updated this revision to Diff 44445.Sep 23 2024, 10:22 AM

makes more sense to have the FetchAllCommunityInfosWithNamesResponse in this diff instead of the previous

Harbormaster completed remote builds in B31783: Diff 44445.Sep 23 2024, 10:38 AM
Harbormaster completed remote builds in B31781: Diff 44443.Sep 23 2024, 10:50 AM
ashoat accepted this revision.Sep 24 2024, 9:43 AM
This revision is now accepted and ready to land.Sep 24 2024, 9:43 AM
Closed by commit rCOMMe9076b23f303: [keyserver] new responder function to fetch all community infos with names (authored by varun). · Explain WhySep 24 2024, 10:57 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMe9076b23f303: [keyserver] new responder function to fetch all community infos with names.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
27 lines

Diff 44443

View Options

keyserver/src/responders/community-responders.js

Show All 20 Lines
import { useNewThread } from 'lib/actions/thread-actions.js'; import { useNewThread } from 'lib/actions/thread-actions.js';
import { import {
uploadMultimedia, uploadMultimedia,
updateMultimediaMessageMediaActionType, updateMultimediaMessageMediaActionType,
useBlobServiceUpload, useBlobServiceUpload,
type MultimediaUploadCallbacks, type MultimediaUploadCallbacks,
type MultimediaUploadExtras, type MultimediaUploadExtras,
type BlobServiceUploadAction, type BlobServiceUploadAction,
type BlobServiceUploadResult,
} from 'lib/actions/upload-actions.js'; } from 'lib/actions/upload-actions.js';
import commStaffCommunity from 'lib/facts/comm-staff-community.js'; import commStaffCommunity from 'lib/facts/comm-staff-community.js';
import { pathFromURI, replaceExtension } from 'lib/media/file-utils.js'; import { pathFromURI, replaceExtension } from 'lib/media/file-utils.js';
import { import {
isLocalUploadID, isLocalUploadID,
getNextLocalUploadID, getNextLocalUploadID,
} from 'lib/media/media-utils.js'; } from 'lib/media/media-utils.js';
import { videoDurationLimit } from 'lib/media/video-utils.js'; import { videoDurationLimit } from 'lib/media/video-utils.js';
▲ Show 20 Lines • Show All 797 Lines • ▼ Show 20 Lines ): Promise<?string> {
const { hasWiFi } = this.props; const { hasWiFi } = this.props;
const uploadStart = Date.now(); const uploadStart = Date.now();
let uploadExceptionMessage, let uploadExceptionMessage,
uploadResult, uploadResult,
uploadThumbnailResult, uploadThumbnailResult,
mediaMissionResult; mediaMissionResult;
try { try {
const uploadPromises = [];
if ( if (
this.useBlobServiceUploads && this.useBlobServiceUploads &&
(processedMedia.mediaType === 'encrypted_photo' || (processedMedia.mediaType === 'encrypted_photo' ||
processedMedia.mediaType === 'encrypted_video') processedMedia.mediaType === 'encrypted_video')
) { ) {
uploadPromises.push( const uploadPromise = this.props.blobServiceUpload({
this.props.blobServiceUpload({
uploadInput: { uploadInput: {
blobInput: { blobInput: {
type: 'uri', type: 'uri',
uri: uploadURI, uri: uploadURI,
filename: filename, filename: filename,
mimeType: mime, mimeType: mime,
}, },
blobHash: processedMedia.blobHash, blobHash: processedMedia.blobHash,
encryptionKey: processedMedia.encryptionKey, encryptionKey: processedMedia.encryptionKey,
dimensions: processedMedia.dimensions, dimensions: processedMedia.dimensions,
thumbHash: thumbHash:
processedMedia.mediaType === 'encrypted_photo' processedMedia.mediaType === 'encrypted_photo'
? processedMedia.thumbHash ? processedMedia.thumbHash
: null, : null,
}, },
keyserverOrThreadID: threadInfo.id, keyserverOrThreadID: threadInfo.id,
callbacks: { callbacks: {
blobServiceUploadHandler, blobServiceUploadHandler,
onProgress: (percent: number) => { onProgress: (percent: number) => {
this.setProgress( this.setProgress(
localMessageID, localMessageID,
localMediaID, localMediaID,
'uploading', 'uploading',
percent, percent,
); );
}, },
}, },
}), });
);
if (processedMedia.mediaType === 'encrypted_video') { const uploadThumbnailPromise: Promise<?BlobServiceUploadResult> =
uploadPromises.push( (async () => {
this.props.blobServiceUpload({ if (processedMedia.mediaType !== 'encrypted_video') {
return undefined;
}
return await this.props.blobServiceUpload({
uploadInput: { uploadInput: {
blobInput: { blobInput: {
type: 'uri', type: 'uri',
uri: processedMedia.uploadThumbnailURI, uri: processedMedia.uploadThumbnailURI,
filename: replaceExtension(`thumb${filename}`, 'jpg'), filename: replaceExtension(`thumb${filename}`, 'jpg'),
mimeType: 'image/jpeg', mimeType: 'image/jpeg',
}, },
blobHash: processedMedia.thumbnailBlobHash, blobHash: processedMedia.thumbnailBlobHash,
encryptionKey: processedMedia.thumbnailEncryptionKey, encryptionKey: processedMedia.thumbnailEncryptionKey,
loop: false, loop: false,
dimensions: processedMedia.dimensions, dimensions: processedMedia.dimensions,
thumbHash: processedMedia.thumbHash, thumbHash: processedMedia.thumbHash,
}, },
keyserverOrThreadID: threadInfo.id, keyserverOrThreadID: threadInfo.id,
callbacks: { callbacks: {
blobServiceUploadHandler, blobServiceUploadHandler,
}, },
}), });
); })();
}
[uploadResult, uploadThumbnailResult] = await Promise.all( [uploadResult, uploadThumbnailResult] = await Promise.all([
uploadPromises, uploadPromise,
); uploadThumbnailPromise,
]);
} else { } else {
uploadPromises.push( const uploadPromise = this.props.uploadMultimedia(
this.props.uploadMultimedia(
{ uri: uploadURI, name: filename, type: mime }, { uri: uploadURI, name: filename, type: mime },
{ {
...processedMedia.dimensions, ...processedMedia.dimensions,
loop: loop:
processedMedia.mediaType === 'video' || processedMedia.mediaType === 'video' ||
processedMedia.mediaType === 'encrypted_video' processedMedia.mediaType === 'encrypted_video'
? processedMedia.loop ? processedMedia.loop
: undefined, : undefined,
encryptionKey: processedMedia.encryptionKey, encryptionKey: processedMedia.encryptionKey,
thumbHash: thumbHash:
processedMedia.mediaType === 'photo' || processedMedia.mediaType === 'photo' ||
processedMedia.mediaType === 'encrypted_photo' processedMedia.mediaType === 'encrypted_photo'
? processedMedia.thumbHash ? processedMedia.thumbHash
: null, : null,
}, },
{ {
onProgress: (percent: number) => onProgress: (percent: number) =>
this.setProgress( this.setProgress(
localMessageID, localMessageID,
localMediaID, localMediaID,
'uploading', 'uploading',
percent, percent,
), ),
uploadBlob: this.uploadBlob, uploadBlob: this.uploadBlob,
}, },
),
); );
const uploadThumbnailPromise: Promise<?UploadMultimediaResult> =
(async () => {
if ( if (
processedMedia.mediaType === 'video' || processedMedia.mediaType !== 'video' &&
processedMedia.mediaType === 'encrypted_video' processedMedia.mediaType !== 'encrypted_video'
) { ) {
uploadPromises.push( return undefined;
this.props.uploadMultimedia( }
return await this.props.uploadMultimedia(
{ {
uri: processedMedia.uploadThumbnailURI, uri: processedMedia.uploadThumbnailURI,
name: replaceExtension(`thumb${filename}`, 'jpg'), name: replaceExtension(`thumb${filename}`, 'jpg'),
type: 'image/jpeg', type: 'image/jpeg',
}, },
{ {
...processedMedia.dimensions, ...processedMedia.dimensions,
loop: false, loop: false,
encryptionKey: processedMedia.thumbnailEncryptionKey, encryptionKey: processedMedia.thumbnailEncryptionKey,
thumbHash: processedMedia.thumbHash, thumbHash: processedMedia.thumbHash,
}, },
{ {
uploadBlob: this.uploadBlob, uploadBlob: this.uploadBlob,
}, },
),
);
}
[uploadResult, uploadThumbnailResult] = await Promise.all(
uploadPromises,
); );
})();
[uploadResult, uploadThumbnailResult] = await Promise.all([
uploadPromise,
uploadThumbnailPromise,
]);
} }
mediaMissionResult = { success: true }; mediaMissionResult = { success: true };
} catch (e) { } catch (e) {
uploadExceptionMessage = getMessageForException(e); uploadExceptionMessage = getMessageForException(e);
onUploadFailed(localMediaID, 'upload failed'); onUploadFailed(localMediaID, 'upload failed');
mediaMissionResult = { mediaMissionResult = {
success: false, success: false,
reason: 'http_upload_failed', reason: 'http_upload_failed',
▲ Show 20 Lines • Show All 787 Lines • Show Last 20 Lines