Paths

Table of Contentst

[lib] Merge viewerID into ProcessDMOperationUtilities
ClosedPublic
Actions

Authored by ashoat on Sep 20 2024, 1:30 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities

Summary

Following feedback in D13391.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 20 2024, 1:30 PM

ashoat mentioned this in D13391: [lib] Add viewerID to DMOperationSpec.notificationsCreationData.Sep 20 2024, 1:31 PM

Harbormaster completed remote builds in B31741: Diff 44375.Sep 20 2024, 1:52 PM

ashoat requested review of this revision.Sep 20 2024, 1:52 PM

kamil accepted this revision.Sep 20 2024, 2:12 PM

kamil added inline comments.

lib/shared/dm-ops/process-dm-ops.js
86–89 ↗	(On Diff #44375)	is it needed? Why can't we keep using `baseUtilities`?

This revision is now accepted and ready to land.Sep 20 2024, 2:12 PM

ashoat added inline comments.Sep 20 2024, 2:53 PM

lib/shared/dm-ops/process-dm-ops.js
86–89 ↗	(On Diff #44375)	Flow needed this

Closed by commit rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities. · Explain WhySep 20 2024, 2:55 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

add-members-spec.js

7 lines

add-viewer-to-thread-members-spec.js

9 lines

change-thread-read-status-spec.js

5 lines

change-thread-settings-spec.js

2 lines

change-thread-subscription.js

5 lines

create-entry-spec.js

1 line

create-sidebar-spec.js

4 lines

create-thread-spec.js

8 lines

2 lines

4 lines

2 lines

9 lines

10 lines

44 lines

remove-members-spec.js

7 lines

send-edit-message-spec.js

1 line

send-multimedia-message-spec.js

1 line

send-reaction-message-spec.js

1 line

send-text-message-spec.js

1 line

update-relationship-spec.js

14 lines

Diff 44394

View Options

lib/shared/dm-ops/add-members-spec.js

View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

View Options

lib/shared/dm-ops/change-thread-settings-spec.js

View Options

lib/shared/dm-ops/change-thread-subscription.js

View Options

lib/shared/dm-ops/create-entry-spec.js

View Options

lib/shared/dm-ops/create-sidebar-spec.js

View Options

lib/shared/dm-ops/create-thread-spec.js

View Options

lib/shared/dm-ops/delete-entry-spec.js

View Options

lib/shared/dm-ops/dm-op-spec.js

View Options

lib/shared/dm-ops/edit-entry-spec.js

View Options

lib/shared/dm-ops/join-thread-spec.js

View Options

lib/shared/dm-ops/leave-thread-spec.js

View Options

lib/shared/dm-ops/process-dm-ops.js

View Options

lib/shared/dm-ops/remove-members-spec.js

View Options

lib/shared/dm-ops/send-edit-message-spec.js

View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

View Options

lib/shared/dm-ops/send-reaction-message-spec.js

View Options

lib/shared/dm-ops/send-text-message-spec.js

View Options

lib/shared/dm-ops/update-relationship-spec.js

[lib] Merge viewerID into ProcessDMOperationUtilitiesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44394

lib/shared/dm-ops/add-members-spec.js

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

lib/shared/dm-ops/change-thread-read-status-spec.js

lib/shared/dm-ops/change-thread-settings-spec.js

lib/shared/dm-ops/change-thread-subscription.js

lib/shared/dm-ops/create-entry-spec.js

lib/shared/dm-ops/create-sidebar-spec.js

lib/shared/dm-ops/create-thread-spec.js

lib/shared/dm-ops/delete-entry-spec.js

lib/shared/dm-ops/dm-op-spec.js

lib/shared/dm-ops/edit-entry-spec.js

lib/shared/dm-ops/join-thread-spec.js

lib/shared/dm-ops/leave-thread-spec.js

lib/shared/dm-ops/process-dm-ops.js

lib/shared/dm-ops/remove-members-spec.js

lib/shared/dm-ops/send-edit-message-spec.js

lib/shared/dm-ops/send-multimedia-message-spec.js

lib/shared/dm-ops/send-reaction-message-spec.js

lib/shared/dm-ops/send-text-message-spec.js

lib/shared/dm-ops/update-relationship-spec.js

[lib] Merge viewerID into ProcessDMOperationUtilities
ClosedPublic
Actions

Revision Contents
Changeset List