Page MenuHomePhabricator
Differential D13412

[lib] Merge viewerID into ProcessDMOperationUtilities
ClosedPublic
Actions

Authored by ashoat on Fri, Sep 20, 6:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 17, 10:03 PM
Unknown Object (File)
Sat, Oct 12, 1:50 AM
Unknown Object (File)
Sat, Oct 12, 1:26 AM
Unknown Object (File)
Fri, Oct 11, 9:06 PM
Unknown Object (File)
Mon, Oct 7, 2:16 PM
Unknown Object (File)
Thu, Oct 3, 7:26 PM
Unknown Object (File)
Sun, Sep 29, 8:17 PM
Unknown Object (File)
Sat, Sep 28, 5:29 PM
View All 25 Files
Subscribers
None

Details

Reviewers
kamil
tomek
Commits
rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities
Summary

Following feedback in D13391.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/relationship
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Fri, Sep 20, 6:30 AM
ashoat mentioned this in D13391: [lib] Add viewerID to DMOperationSpec.notificationsCreationData.Fri, Sep 20, 6:31 AM
Harbormaster completed remote builds in B31741: Diff 44375.Fri, Sep 20, 6:52 AM
ashoat requested review of this revision.Fri, Sep 20, 6:52 AM
kamil accepted this revision.Fri, Sep 20, 7:12 AM
kamil added inline comments.
lib/shared/dm-ops/process-dm-ops.js
86–89

is it needed? Why can't we keep using baseUtilities?

This revision is now accepted and ready to land.Fri, Sep 20, 7:12 AM
ashoat added inline comments.Fri, Sep 20, 7:53 AM
lib/shared/dm-ops/process-dm-ops.js
86–89

Flow needed this

Closed by commit rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities (authored by ashoat). · Explain WhyFri, Sep 20, 7:55 AM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM8703bff04d40: [lib] Merge viewerID into ProcessDMOperationUtilities.

Revision Contents
Changeset List

Diff 44375

View Options

lib/shared/dm-ops/add-members-spec.js

Loading...
View Options

lib/shared/dm-ops/add-viewer-to-thread-members-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-read-status-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Loading...
View Options

lib/shared/dm-ops/change-thread-subscription.js

Loading...
View Options

lib/shared/dm-ops/create-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Loading...
View Options

lib/shared/dm-ops/create-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/delete-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/dm-op-spec.js

Loading...
View Options

lib/shared/dm-ops/edit-entry-spec.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-multimedia-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...
View Options

lib/shared/dm-ops/update-relationship-spec.js

Loading...