Page MenuHomePhabricator

[lib] Use `UPDATE_THREAD_READ_STATUS` update to update the read status
ClosedPublic

Authored by tomek on Sep 23 2024, 4:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 3:53 PM
Unknown Object (File)
Sun, Nov 17, 3:24 PM
Unknown Object (File)
Sat, Nov 9, 11:50 PM
Unknown Object (File)
Fri, Nov 8, 7:04 PM
Unknown Object (File)
Fri, Nov 8, 7:04 PM
Unknown Object (File)
Fri, Nov 8, 7:01 PM
Unknown Object (File)
Thu, Nov 7, 5:26 PM
Unknown Object (File)
Thu, Nov 7, 1:32 PM
Subscribers

Details

Summary

This update is more convenient because it doesn't override the whole thread, which fixes a bug where the unread status operation sometimes swallows other operations. For the thick threads, this update should also bump a timestamp.

https://linear.app/comm/issue/ENG-9343/updating-thread-unread-status-sometimes-swallows-queued-operations

Test Plan
  1. Send a message as one user and check if a thread of the other used got marked as unread
  2. Send a message as a user and check if a thread doesn't get marked as unread on another device of the same user
  3. Check if marking as unread results in a thread being marked as unread on another device of the same user

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable