Page MenuHomePhabricator

[lib] Use `UPDATE_THREAD_READ_STATUS` update to update the read status
ClosedPublic

Authored by tomek on Mon, Sep 23, 4:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 12:53 PM
Unknown Object (File)
Sat, Sep 28, 4:22 AM
Unknown Object (File)
Wed, Sep 25, 12:41 AM
Unknown Object (File)
Wed, Sep 25, 12:41 AM
Unknown Object (File)
Wed, Sep 25, 12:40 AM
Unknown Object (File)
Wed, Sep 25, 12:05 AM
Subscribers

Details

Summary

This update is more convenient because it doesn't override the whole thread, which fixes a bug where the unread status operation sometimes swallows other operations. For the thick threads, this update should also bump a timestamp.

https://linear.app/comm/issue/ENG-9343/updating-thread-unread-status-sometimes-swallows-queued-operations

Test Plan
  1. Send a message as one user and check if a thread of the other used got marked as unread
  2. Send a message as a user and check if a thread doesn't get marked as unread on another device of the same user
  3. Check if marking as unread results in a thread being marked as unread on another device of the same user

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable