[lib] Make NotificationsCreationData read-only
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 9:59 AM.

Tags

None

Referenced Files

	F3313008: D13522.diff
	Tue, Nov 19, 11:22 AM

	Unknown Object (File)
	Sun, Nov 10, 4:18 PM

	Unknown Object (File)
	Fri, Nov 8, 3:02 AM

	Unknown Object (File)
	Fri, Nov 8, 3:02 AM

	Unknown Object (File)
	Fri, Nov 8, 3:02 AM

	Unknown Object (File)
	Fri, Nov 1, 4:22 PM

	Unknown Object (File)
	Fri, Nov 1, 5:56 AM

	Unknown Object (File)
	Fri, Nov 1, 5:35 AM

View All 38 Files

Subscribers

None

Details

Reviewers

tomek
kamil

Commits

rCOMM409d158eee0e: [lib] Make NotificationsCreationData read-only

Summary

Noticed that these were accidentally not marked as read-only.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/notifs

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Sep 30 2024, 9:59 AM

Unrelated capitalization fix

Harbormaster completed remote builds in B31936: Diff 44693.Sep 30 2024, 10:17 AM

Harbormaster completed remote builds in B31937: Diff 44694.Sep 30 2024, 10:21 AM

ashoat requested review of this revision.Sep 30 2024, 10:21 AM

kamil accepted this revision.Oct 1 2024, 1:37 AM

This revision is now accepted and ready to land.Oct 1 2024, 1:37 AM

Closed by commit rCOMM409d158eee0e: [lib] Make NotificationsCreationData read-only (authored by ashoat). · Explain WhyOct 1 2024, 8:06 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM409d158eee0e: [lib] Make NotificationsCreationData read-only.

Revision Contents
Changeset List

Path

Size

lib/

push/

send-utils.js

4 lines

types/

notif-types.js

4 lines

Diff 44693

View Options

lib/push/send-utils.js