[lib] Hide initialThreadState.memberIDs from GENESIS
ClosedPublic
Actions

Authored by ashoat on Sep 30 2024, 2:27 PM.

Details

Reviewers

varun
will

Commits

rCOMM336252dccbf0: [lib] Hide initialThreadState.memberIDs from GENESIS

Summary

We hide the members list of GENESIS. For similar reasons, we should hide the list of initial members.

This addresses ENG-9430; more context there.

Test Plan

I added an || true, and then logged out and back in on web and confirmed that all thread creation robotext were missing "and added A and B" at the end

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 30 2024, 2:27 PM

Herald added a subscriber: tomek. · View Herald TranscriptSep 30 2024, 2:27 PM

Harbormaster completed remote builds in B31943: Diff 44700.Sep 30 2024, 2:44 PM

ashoat requested review of this revision.Sep 30 2024, 2:44 PM

will accepted this revision.Sep 30 2024, 3:34 PM

This revision is now accepted and ready to land.Sep 30 2024, 3:34 PM

Closed by commit rCOMM336252dccbf0: [lib] Hide initialThreadState.memberIDs from GENESIS (authored by ashoat). · Explain WhySep 30 2024, 4:50 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM336252dccbf0: [lib] Hide initialThreadState.memberIDs from GENESIS.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

create-thread-message-spec.js

13 lines

Diff 44709

View Options

lib/shared/messages/create-thread-message-spec.js

[lib] Hide initialThreadState.memberIDs from GENESISClosedPublicActions