Page MenuHomePhabricator
Differential D13530

[lib] use v2 relevant followers API to find farcaster friends
ClosedPublic
Actions

Authored by varun on Mon, Sep 30, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 2, 1:43 AM
Unknown Object (File)
Tue, Oct 1, 7:35 PM
Unknown Object (File)
Tue, Oct 1, 4:30 PM
Unknown Object (File)
Tue, Oct 1, 4:28 PM
Unknown Object (File)
Tue, Oct 1, 11:40 AM
Unknown Object (File)
Tue, Oct 1, 11:40 AM
Unknown Object (File)
Tue, Oct 1, 11:39 AM
Unknown Object (File)
Tue, Oct 1, 11:36 AM
Subscribers
tomek

Details

Reviewers
ashoat
will
Commits
rCOMM288f98412b1a: [lib] use v2 relevant followers API to find farcaster friends
Summary

this API returns what we want -- farcaster mutuals. and it seems to work pretty consistently, unlike the paginated v1 followers API.

Test Plan

successfully got back farcaster mutuals for dwr.eth (fid 3), who has a ton of followers

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Mon, Sep 30, 3:41 PM
Herald added a subscriber: tomek. · View Herald TranscriptMon, Sep 30, 3:41 PM
varun added a comment.Mon, Sep 30, 3:48 PM

also confirmed that threads are created with farcaster mutuals who are also on comm

varun published this revision for review.Mon, Sep 30, 3:56 PM
will accepted this revision.Mon, Sep 30, 3:59 PM
This revision is now accepted and ready to land.Mon, Sep 30, 3:59 PM
Harbormaster completed remote builds in B31945: Diff 44702.Mon, Sep 30, 4:00 PM
ashoat requested changes to this revision.Mon, Sep 30, 4:42 PM
ashoat added inline comments.
lib/utils/neynar-client.js
10–11 ↗(On Diff #44702)

Read-only

74–75 ↗(On Diff #44702)

How could this possibly work if you're not taking the viewer's FID into account?

This revision now requires changes to proceed.Mon, Sep 30, 4:42 PM
ashoat accepted this revision.Mon, Sep 30, 4:43 PM

Never mind, sorry – the viewer's FID is the only input taken

lib/utils/neynar-client.js
74–75 ↗(On Diff #44702)

Oops sorry

This revision is now accepted and ready to land.Mon, Sep 30, 4:43 PM
ashoat added a comment.Mon, Sep 30, 4:43 PM

(Please make read-only before landing)

Closed by commit rCOMM288f98412b1a: [lib] use v2 relevant followers API to find farcaster friends (authored by varun). · Explain WhyMon, Sep 30, 5:37 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM288f98412b1a: [lib] use v2 relevant followers API to find farcaster friends.

Revision Contents
Changeset List

PathSize
lib/
utils/
86 lines

Diff 44711

View Options

lib/utils/neynar-client.js

Loading...