Differential D13694

[keyserver] move async iife to standalone function
ClosedPublic
Actions

Authored by varun on Oct 10 2024, 11:31 AM.

Details

Reviewers

ashoat

Commits

rCOMM8a98670d7370: [keyserver] move async iife to standalone function

Summary

keyserver.js is already massive, and the async iife in the middle makes it harder to follow

Depends on D13667

Test Plan

cleared the access token from the metadata table and ran keyserver as a secondary node. confirmed that node polled every 5 seconds for identity info.

killed and ran keyserver as primary. access token was added to metadata table.

killed and ran keyserver as secondary again. node was able to fetch access token and did not get stuck in loop

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Oct 10 2024, 11:31 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 10 2024, 11:31 AM

Harbormaster completed remote builds in B32188: Diff 45071.Oct 10 2024, 11:49 AM

varun requested review of this revision.Oct 10 2024, 11:49 AM

Thanks for doing this cleanup! I'm assuming it's a clean refactor, so I didn't review very closely

This revision is now accepted and ready to land.Oct 10 2024, 11:54 AM

use full line length for comments

This revision was landed with ongoing or failed builds.Oct 10 2024, 12:07 PM

Closed by commit rCOMM8a98670d7370: [keyserver] move async iife to standalone function (authored by varun). · Explain Why

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM8a98670d7370: [keyserver] move async iife to standalone function.

Harbormaster completed remote builds in B32192: Diff 45075.Oct 10 2024, 12:22 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

keyserver.js

41 lines

utils/

keyserver-services-setup.js

49 lines

Diff 45080

View Options

keyserver/src/keyserver.js