Page MenuHomePhabricator
Differential D13717

[lib] Fix selecting custom Neynar channel
ClosedPublic
Actions

Authored by ashoat on Oct 15 2024, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 28, 2:09 AM
Unknown Object (File)
Fri, Feb 28, 1:39 AM
Unknown Object (File)
Wed, Feb 19, 8:13 AM
Unknown Object (File)
Jan 19 2025, 4:09 PM
Unknown Object (File)
Jan 19 2025, 4:09 PM
Unknown Object (File)
Jan 19 2025, 4:08 PM
Unknown Object (File)
Jan 19 2025, 4:08 PM
Unknown Object (File)
Jan 9 2025, 1:46 AM
View All 55 Files
Subscribers
tomek

Details

Reviewers
will
varun
Commits
rCOMM9f60dd286748: [lib] Fix selecting custom Neynar channel
Summary

This addresses ENG-9340.

We were comparing the human-readable name when we should be comparing the channel ID.

Test Plan
  1. I compiled a prod build to a local iOS simulator
  2. I logged in as a prod user with a linked Farcaster account
  3. I went to the three-dots settings menu for a community that the user is an admin of, and selected "Tag Farcaster channel"
  4. I selected the "other" option and then typed in "new-york"
  5. I confirmed I was able to link the channel successfully

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
utils/
2 lines

Diff 45206

View Options

lib/utils/neynar-client.js

// @flow // @flow
import { requireNativeModule } from 'expo-modules-core'; import { requireNativeModule } from 'expo-modules-core';
import invariant from 'invariant'; import invariant from 'invariant';
const KEY_SIZE = 32; // bytes const KEY_SIZE = 32; // bytes
const IV_LENGTH = 12; // bytes, IV - unique Initialization Vector (nonce) const IV_LENGTH = 12; // bytes, IV - unique Initialization Vector (nonce)
const TAG_LENGTH = 16; // bytes - GCM auth tag const TAG_LENGTH = 16; // bytes - GCM auth tag
const AESCryptoModule: { const AESCryptoModule: {
+generateKey: (destination: Uint8Array) => void, +generateKey: (destination: Uint8Array) => void,
+generateIV: (destination: Uint8Array) => void,
+encrypt: ( +encrypt: (
key: Uint8Array, key: Uint8Array,
data: Uint8Array, data: Uint8Array,
destination: Uint8Array, destination: Uint8Array,
initializationVector: Uint8Array,
) => void, ) => void,
+decrypt: ( +decrypt: (
key: Uint8Array, key: Uint8Array,
data: Uint8Array, data: Uint8Array,
destination: Uint8Array, destination: Uint8Array,
) => void, ) => void,
} = requireNativeModule('AESCrypto'); } = requireNativeModule('AESCrypto');
export function generateKey(): Uint8Array { export function generateKey(): Uint8Array {
const keyBuffer = new Uint8Array(KEY_SIZE); const keyBuffer = new Uint8Array(KEY_SIZE);
AESCryptoModule.generateKey(keyBuffer); AESCryptoModule.generateKey(keyBuffer);
return keyBuffer; return keyBuffer;
} }
export function encrypt(key: Uint8Array, data: Uint8Array): Uint8Array { export function generateIV(): Uint8Array {
const ivBuffer = new Uint8Array(IV_LENGTH);
AESCryptoModule.generateIV(ivBuffer);
return ivBuffer;
}
export function encrypt(
key: Uint8Array,
data: Uint8Array,
initializationVector?: ?Uint8Array,
): Uint8Array {
const sealedDataBuffer = new Uint8Array(data.length + IV_LENGTH + TAG_LENGTH); const sealedDataBuffer = new Uint8Array(data.length + IV_LENGTH + TAG_LENGTH);
AESCryptoModule.encrypt(key, data, sealedDataBuffer); const iv = initializationVector ?? new Uint8Array(0);
AESCryptoModule.encrypt(key, data, sealedDataBuffer, iv);
return sealedDataBuffer; return sealedDataBuffer;
} }
export function decrypt(key: Uint8Array, data: Uint8Array): Uint8Array { export function decrypt(key: Uint8Array, data: Uint8Array): Uint8Array {
invariant(data.length >= IV_LENGTH + TAG_LENGTH, 'Invalid data length'); invariant(data.length >= IV_LENGTH + TAG_LENGTH, 'Invalid data length');
const plaintextBuffer = new Uint8Array(data.length - IV_LENGTH - TAG_LENGTH); const plaintextBuffer = new Uint8Array(data.length - IV_LENGTH - TAG_LENGTH);
AESCryptoModule.decrypt(key, data, plaintextBuffer); AESCryptoModule.decrypt(key, data, plaintextBuffer);
return plaintextBuffer; return plaintextBuffer;
} }