If the user unlinks their Farcaster identity, we should set it to NO_FID_METADATA so they don't get prompted again.
Details
Details
I looked through the code for places that call useCurrentUserFID to see where undefined/null is differentiated. I saw that ConnectFarcasterAlertHandler calls shouldSkipConnectFarcasterAlert, which differentiates the two. I confirmed that setting NO_FID_METADATA is better, so that we return null and so that ConnectFarcasterAlertHandler doesn't prompt the user to connect their Farcaster account in this case
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
lib/utils/farcaster-utils.js | ||
---|---|---|
26 ↗ | (On Diff #45237) | See here for the significance of setting NO_FID_METADATA instead of wiping the entry. We'll return null here instead of undefined |