this change means that when fetchThreadInfos is called with an old client as the viewer, the raw thread info will contain a null avatar
the min native and web versions were set to the same versions as fetchKnownUserInfos
Depends on D13746
Details
Details
fetched threads from old native client and got back default avatar for farcaster avatar threads
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/fetchers/thread-fetchers.js | ||
|---|---|---|
| 315–316 ↗ | (On Diff #45272) |
Wait, is this right? I'm a bit confused... won't clients need the changes in the preceding diffs in the stack in order to be able to render thread avatars set to { type: 'farcaster' }? If not, can you:
(My instinct is that you want NEXT_CODE_VERSION here) |
| lib/shared/thread-utils.js | ||
| 907–911 ↗ | (On Diff #45272) | I think this condition would be more clear if inverted |
| keyserver/src/fetchers/thread-fetchers.js | ||
|---|---|---|
| 315–316 ↗ | (On Diff #45272) |
in the case of the former, the defaultAnonymousUserEmojiAvatar will be returned by the hook. but i'm realizing it would be better to use NEXT_CODE_VERSION here to display a default thread avatar instead... will update this diff |
Comment Actions
Versions above 405 but below the next code version will have either the before or after of this landed commit, or they will have the changes from this diff stack which include support for farcaster thread avatars
Hard to follow what you're trying to say here, but since you're using NEXT_CODE_VERSION now I'll accept