Page MenuHomePhabricator
Differential D13787

[lib] Close tunnelbroker socket when app is in background
ClosedPublic
Actions

Authored by angelika on Thu, Oct 24, 12:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 5:39 PM
Unknown Object (File)
Fri, Nov 8, 5:13 PM
Unknown Object (File)
Fri, Nov 8, 11:50 AM
Unknown Object (File)
Fri, Nov 8, 9:34 AM
Unknown Object (File)
Fri, Nov 8, 8:25 AM
Unknown Object (File)
Thu, Nov 7, 9:32 PM
Unknown Object (File)
Mon, Nov 4, 8:00 AM
Unknown Object (File)
Mon, Nov 4, 12:50 AM
View All 12 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM603f6924736f: [lib] Close tunnelbroker socket when app is in background
Summary

This diff closes tunnelbroker socket when app goes to background in order to prevent messages from decrypting twice and weird socket state.

https://linear.app/comm/issue/ENG-9741/tunnelbroker-socket-onmessage-is-triggered-before-re-opening-socket

Test Plan
  1. Run the app
  2. Put the app in the background
  3. Send some DMs to the app
  4. Bring the app to the foreground
  5. Observe in logs that the socket is closed after going to the background and verify that no message is received before closing the socket

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
9 lines

Diff 45438

View Options

lib/tunnelbroker/tunnelbroker-context.js

Loading...