Page MenuHomePhabricator
Differential D13787

[lib] Close tunnelbroker socket when app is in background
ClosedPublic
Actions

Authored by angelika on Oct 24 2024, 12:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 10:43 AM
Unknown Object (File)
Sun, Mar 30, 4:46 AM
Unknown Object (File)
Sat, Mar 29, 11:37 PM
Unknown Object (File)
Sat, Mar 29, 3:18 PM
Unknown Object (File)
Mar 9 2025, 4:43 PM
Unknown Object (File)
Feb 18 2025, 4:05 PM
Unknown Object (File)
Feb 18 2025, 4:05 PM
Unknown Object (File)
Feb 18 2025, 4:04 PM
View All 49 Files
Subscribers
ashoat

Details

Reviewers
tomek
kamil
Commits
rCOMM603f6924736f: [lib] Close tunnelbroker socket when app is in background
Summary

This diff closes tunnelbroker socket when app goes to background in order to prevent messages from decrypting twice and weird socket state.

https://linear.app/comm/issue/ENG-9741/tunnelbroker-socket-onmessage-is-triggered-before-re-opening-socket

Test Plan
  1. Run the app
  2. Put the app in the background
  3. Send some DMs to the app
  4. Bring the app to the foreground
  5. Observe in logs that the socket is closed after going to the background and verify that no message is received before closing the socket

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
9 lines

Diff 45438

View Options

lib/tunnelbroker/tunnelbroker-context.js

Show All 34 Linesimport {
roleIsAdminRole, roleIsAdminRole,
threadIsPending, threadIsPending,
getPendingThreadID, getPendingThreadID,
} from '../shared/thread-utils.js'; } from '../shared/thread-utils.js';
import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types'; import type { ClientAvatar, ClientEmojiAvatar } from '../types/avatar-types';
import type { EntryInfo } from '../types/entry-types.js'; import type { EntryInfo } from '../types/entry-types.js';
import type { MessageStore, RawMessageInfo } from '../types/message-types.js'; import type { MessageStore, RawMessageInfo } from '../types/message-types.js';
import type { import type {
MinimallyEncodedRelativeMemberInfo,
ThreadInfo, ThreadInfo,
RawThreadInfo, RawThreadInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import { import {
threadTypes, threadTypes,
threadTypeIsCommunityRoot, threadTypeIsCommunityRoot,
type ThreadType, type ThreadType,
} from '../types/thread-types-enum.js'; } from '../types/thread-types-enum.js';
import type { import type {
SidebarInfo, SidebarInfo,
RelativeMemberInfo, LegacyRelativeMemberInfo,
MixedRawThreadInfos, MixedRawThreadInfos,
RawThreadInfos, RawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { dateString, dateFromString } from '../utils/date-utils.js'; import { dateString, dateFromString } from '../utils/date-utils.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
▲ Show 20 Lines • Show All 282 Lines • ▼ Show 20 Lines
const baseOtherUsersButNoOtherAdmins: ( const baseOtherUsersButNoOtherAdmins: (
threadID: string, threadID: string,
) => (BaseAppState<>) => boolean = (threadID: string) => ) => (BaseAppState<>) => boolean = (threadID: string) =>
createSelector( createSelector(
(state: BaseAppState<>) => state.threadStore.threadInfos[threadID], (state: BaseAppState<>) => state.threadStore.threadInfos[threadID],
relativeMemberInfoSelectorForMembersOfThread(threadID), relativeMemberInfoSelectorForMembersOfThread(threadID),
( (
threadInfo: ?RawThreadInfo, threadInfo: ?RawThreadInfo,
members: $ReadOnlyArray<RelativeMemberInfo>, members: $ReadOnlyArray<
LegacyRelativeMemberInfo | MinimallyEncodedRelativeMemberInfo,
>,
): boolean => { ): boolean => {
if (!threadInfo) { if (!threadInfo) {
return false; return false;
} }
if (!threadHasAdminRole(threadInfo)) { if (!threadHasAdminRole(threadInfo)) {
return false; return false;
} }
let otherUsersExist = false; let otherUsersExist = false;
▲ Show 20 Lines • Show All 198 Lines • Show Last 20 Lines