[native] Add loading button state to CreateSIWEBackupMessageBase
ClosedPublic
Actions

Authored by ashoat on Oct 29 2024, 7:53 AM.

Details

Reviewers

will
varun

Commits

rCOMMb66626ca8b8a: [native] Add loading button state to CreateSIWEBackupMessageBase

Summary

Noticed that when the user presses the button to open SIWEPanel, we don't change the button to a loading state like we do for the ConnectEthereum screen here.

This diff adds the loading state to the button, which improves the responsiveness of the UX.

Test Plan

I tested in my local environment to make sure the button changed to a loading state

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Oct 29 2024, 7:53 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 29 2024, 7:53 AM

Harbormaster completed remote builds in B32400: Diff 45422.Oct 29 2024, 8:18 AM

ashoat requested review of this revision.Oct 29 2024, 8:18 AM

varun accepted this revision.Oct 29 2024, 11:04 AM

This revision is now accepted and ready to land.Oct 29 2024, 11:04 AM

Closed by commit rCOMMb66626ca8b8a: [native] Add loading button state to CreateSIWEBackupMessageBase (authored by ashoat). · Explain WhyOct 29 2024, 11:37 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb66626ca8b8a: [native] Add loading button state to CreateSIWEBackupMessageBase.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

siwe-backup-message-creation.react.js

4 lines

Diff 45432

View Options

native/account/registration/siwe-backup-message-creation.react.js

[native] Add loading button state to CreateSIWEBackupMessageBaseClosedPublicActions