Page MenuHomePhabricator
Differential D13813

[keyserver] remove commbot after creating community
AbandonedPublic
Actions

Authored by will on Oct 29 2024, 4:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 1, 9:22 AM
Unknown Object (File)
Sun, Dec 1, 8:00 AM
Unknown Object (File)
Sat, Nov 30, 8:51 AM
Unknown Object (File)
Thu, Nov 28, 10:04 AM
Unknown Object (File)
Wed, Nov 13, 9:07 PM
Unknown Object (File)
Wed, Nov 6, 1:15 PM
Unknown Object (File)
Tue, Nov 5, 1:00 AM
Unknown Object (File)
Mon, Nov 4, 4:03 PM
View All 17 Files
Subscribers
tomek

Details

Reviewers
varun
ashoat
Summary

This removes commbot after it creates the community. There will always be another keysrver admin as it will either be the tagger, channel lead, or the keyserver admin.

Depends on D13775

Test Plan

Tested by auto-creating a community for the dgn channel and confirming that after commbot had created the community, the tagger userID was promoted to admin and commbot did not appear on members.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Oct 29 2024, 4:29 PM
Herald added a subscriber: tomek. · View Herald TranscriptOct 29 2024, 4:29 PM
will updated this revision to Diff 45444.Oct 29 2024, 4:32 PM

rebase

will edited the summary of this revision. (Show Details)Oct 29 2024, 4:33 PM
will added a parent revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
will added a child revision: D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.Oct 29 2024, 4:36 PM
Harbormaster completed remote builds in B32416: Diff 45443.Oct 29 2024, 4:47 PM
Harbormaster completed remote builds in B32417: Diff 45444.Oct 29 2024, 4:50 PM
will requested review of this revision.Oct 29 2024, 4:50 PM
ashoat requested changes to this revision.Oct 29 2024, 7:08 PM

See feedback in D13812 – we wouldn't need to remove commbot if we never add them to the thread

This revision now requires changes to proceed.Oct 29 2024, 7:08 PM
will removed a child revision: D13812: [keyserver] Add dontCheckJoinPermissions override option to createThread for sidebar.Oct 30 2024, 12:16 AM
will added a comment.Oct 30 2024, 11:13 AM

Abandoning this diff. We're going with the approach introduced in https://phab.comm.dev/D13819 where commbot is added as a ghost

will abandoned this revision.Oct 30 2024, 11:13 AM
will removed a parent revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.

Revision Contents
Changeset List

PathSize
keyserver/
src/
responders/
7 lines

Diff 45444

View Options

keyserver/src/responders/farcaster-webhook-responders.js

Loading...