all four of the updated validators here are only ever used to validate thin threads. therefore, they should be thin thread validators
Details
Details
https://linear.app/comm/issue/ENG-9937/narrow-raw-thread-info-validators this linear task enumerates all callsites for these validators. i checked that they're only ever used on the keyserver or to validate keyserver responses. it looks like we don't use these validators for E2EE DMs.
i also did some manual testing by sending messages through my keyserver and sending DMs to other test accounts
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/permissions/minimally-encoded-thread-permissions.test.js | ||
|---|---|---|
| 516–524 ↗ | (On Diff #45852) | I decided not to change the types of the data in these tests because it didn't seem necessary exampleMinimallyEncodedRawThreadInfoA is typed as a RawThreadInfo, but the validator tests that it's in fact a ThinRawThreadInfo similarly, exampleRawThreadInfoA is type LegacyRawThreadInfo, but the validator tests that it's a LegacyThinRawThreadInfo |