Paths

Table of Contentst

Differential D13949

[keyserver][lib] change thread info validators -> thin raw thread info validators
ClosedPublic
Actions

Authored by varun on Fri, Nov 15, 12:35 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rCOMM5e90e9617847: [keyserver][lib] change thread info validators -> thin raw thread info…

Summary

all four of the updated validators here are only ever used to validate thin threads. therefore, they should be thin thread validators

Test Plan

https://linear.app/comm/issue/ENG-9937/narrow-raw-thread-info-validators this linear task enumerates all callsites for these validators. i checked that they're only ever used on the keyserver or to validate keyserver responses. it looks like we don't use these validators for E2EE DMs.

i also did some manual testing by sending messages through my keyserver and sending DMs to other test accounts

Diff Detail

Repository

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Fri, Nov 15, 12:35 PM

varun held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptFri, Nov 15, 12:35 PM

Harbormaster failed remote builds in B32689: Diff 45852!Fri, Nov 15, 12:41 PM

varun published this revision for review.Fri, Nov 15, 12:52 PM

varun added inline comments.

lib/permissions/minimally-encoded-thread-permissions.test.js
516–524	I decided not to change the types of the data in these tests because it didn't seem necessary `exampleMinimallyEncodedRawThreadInfoA` is typed as a `RawThreadInfo`, but the validator tests that it's in fact a `ThinRawThreadInfo` similarly, `exampleRawThreadInfoA` is type `LegacyRawThreadInfo`, but the validator tests that it's a `LegacyThinRawThreadInfo`

Harbormaster completed remote builds in B32689: Diff 45852.Fri, Nov 15, 1:04 PM

I went through each of these on my own and I think it's safe

This revision is now accepted and ready to land.Fri, Nov 15, 2:05 PM

Closed by commit rCOMM5e90e9617847: [keyserver][lib] change thread info validators -> thin raw thread info… (authored by varun). · Explain WhyFri, Nov 15, 4:16 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM5e90e9617847: [keyserver][lib] change thread info validators -> thin raw thread info….

Revision Contents
Changeset List

Path

Size

keyserver/

src/

scripts/

generate-converter-from-validator.js

4 lines

shared/

state-sync/

threads-state-sync-spec.js

8 lines

lib/

permissions/

minimally-encoded-raw-thread-info-validators.js

39 lines

minimally-encoded-thread-permissions.test.js

6 lines

shared/

updates/

join-thread-spec.js

4 lines

update-thread-spec.js

4 lines

types/

minimally-encoded-thread-permissions-types.js

4 lines

request-types.js

4 lines

socket-types.js

4 lines

thread-types-enum.js

4 lines

thread-types.js

8 lines

validation.test.js

9 lines

validators/

redux-state-validators.js

4 lines

thread-validators.js

6 lines

user-validators.js

6 lines

utils/

user-info-extraction-utils.js

4 lines

Diff 45852

keyserver/src/scripts/generate-converter-from-validator.js

Loading...

keyserver/src/shared/state-sync/threads-state-sync-spec.js

Loading...

lib/permissions/minimally-encoded-raw-thread-info-validators.js

Loading...

lib/permissions/minimally-encoded-thread-permissions.test.js

Loading...

lib/shared/updates/join-thread-spec.js

Loading...

lib/shared/updates/update-thread-spec.js

Loading...

lib/types/minimally-encoded-thread-permissions-types.js

Loading...

lib/types/request-types.js

Loading...

lib/types/socket-types.js

Loading...

lib/types/thread-types-enum.js

Loading...

lib/types/thread-types.js

Loading...

lib/types/validation.test.js

Loading...

lib/types/validators/redux-state-validators.js

Loading...

lib/types/validators/thread-validators.js

Loading...

lib/types/validators/user-validators.js

Loading...

lib/utils/user-info-extraction-utils.js

Loading...