Page MenuHomePhabricator

[web] Don't render ThreadListProvider in CommunityDrawer
ClosedPublic

Authored by ashoat on Fri, Nov 22, 7:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 12:55 PM
Unknown Object (File)
Sun, Nov 24, 6:04 AM
Unknown Object (File)
Sun, Nov 24, 1:48 AM
Unknown Object (File)
Sat, Nov 23, 11:03 PM
Unknown Object (File)
Fri, Nov 22, 6:12 PM
Unknown Object (File)
Fri, Nov 22, 6:12 PM
Unknown Object (File)
Fri, Nov 22, 6:12 PM
Subscribers
None

Details

Summary

Searched the codebase and couldn't find any use of ThreadListContext within this component tree. It was initially introduced in D6162, but I couldn't find any uses in that stack either.

This is an expensive component to render, so we should avoid rendering it unless necessary.

Test Plan
  1. I did a thorough search for all consumers of ThreadListContext and confirmed that there were none in this component tree.
  2. I tested the web app in my local environment and didn't see any issues.
  3. I tested the web app in a production setting (my personal server at comm.domains, pointed at my production keyserver on AWS) and didn't see any issues.

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/threadlistprovider
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

I also searched the codebase and didn't see any usage.

This revision is now accepted and ready to land.Mon, Nov 25, 3:21 AM