Page MenuHomePhabricator

[keyserver] Avoid ignorePromiseRejections if isScriptViewer
AcceptedPublic

Authored by ashoat on Thu, Dec 19, 6:22 AM.
Tags
None
Referenced Files
F3496184: D14176.id46583.diff
Thu, Dec 19, 11:35 AM
F3496152: D14176.id.diff
Thu, Dec 19, 11:34 AM
F3496136: D14176.diff
Thu, Dec 19, 11:34 AM
Subscribers
None

Details

Reviewers
tomek
angelika
Summary

When we use ignorePromiseRejections inside a script, it can cause problems because the SQL connection can be shut down before the operation concludes.

As such, we have a pattern to await in those cases. You can see we're already using that pattern in the same file for deletionUpdatesPromise.

Test Plan

Relying on Flow here, as this is a pretty clear and established pattern

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage