[lib] Refactor useLogOut to auto-detect logout flow
ClosedPublic
Actions

Authored by bartek on Dec 20 2024, 11:18 AM.

Details

Reviewers

tomek
kamil

Commits

Summary

Renamed useLogOut to useBaseLogOut
- Made options required
Created new useLogOut without arguments, which automatically chooses correct logout flow basing on usingRestoreFlow and isPrimaryDevice

Test Plan

For both old- and new-flow account, checked that correct logout protocol is chosen when:

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

bartek held this revision as a draft.

bartek published this revision for review.Dec 20 2024, 12:59 PM

native/profile/profile-screen.react.js
575 ↗	(On Diff #46593)	Why are we using legacy logout here?
580 ↗	(On Diff #46593)	Typo
web/settings/account-settings.react.js
52 ↗	(On Diff #46593)	Why are we using legacy logout here?

web/settings/account-settings.react.js
52 ↗	(On Diff #46593)	A few lines below (L67) it is used when `usingRestoreFlow == false` (new login flows disabled).

native/profile/profile-screen.react.js
575 ↗	(On Diff #46593)	Legacy logout is dispatched when `usingRestoreFlow == false`, see `onPressLogOut()` above
580 ↗	(On Diff #46593)	thanks

native/profile/profile-screen.react.js
575 ↗	(On Diff #46593)	Got it! Might be helpful to rename `logOutOptions` to `legacyLogOutOptions`
web/settings/account-settings.react.js
52 ↗	(On Diff #46593)	Got it! Might be helpful to rename `logOutOptions` to `legacyLogOutOptions`