[native_rust_library] avoid triggering backup upload before cleanup
ClosedPublic
Actions

Authored by kamil on Feb 5 2025, 7:22 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMMa38a6e8d4ff7: [native_rust_library] avoid triggering backup upload before cleanup

Summary

I discovered this when testing this for wallet users and looking into logs. We might want to start uploading in the middle of the cleanup process, with this easy change we'll wait for deleting already uploaded files first.

Test Plan

Check logs that there is now upload until files are deleted.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 5 2025, 7:22 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 5 2025, 7:22 AM

kamil published this revision for review.Feb 5 2025, 7:24 AM

kamil edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B33395: Diff 46922!Feb 5 2025, 7:35 AM

tomek accepted this revision.Feb 5 2025, 8:46 AM

This revision is now accepted and ready to land.Feb 5 2025, 8:46 AM

Harbormaster completed remote builds in B33405: Diff 46932.Feb 6 2025, 1:59 AM

Closed by commit rCOMMa38a6e8d4ff7: [native_rust_library] avoid triggering backup upload before cleanup (authored by kamil). · Explain WhyFeb 6 2025, 2:08 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa38a6e8d4ff7: [native_rust_library] avoid triggering backup upload before cleanup.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

backup/

upload_handler.rs

2 lines

Diff 46937

View Options

native/native_rust_library/src/backup/upload_handler.rs

Show First 20 Lines • Show All 113 Lines • ▼ Show 20 Lines	() =>
tab: 'chat',		tab: 'chat',
};		};

dispatch({ type: updateNavInfoActionType, payload });		dispatch({ type: updateNavInfoActionType, payload });
},		},
),		),
[dispatch],		[dispatch],
);		);

		// Handle invalid device token
		const localToken = useSelector(
		state => state.tunnelbrokerDeviceToken.localToken,
		);
		const prevLocalToken = React.useRef(localToken);
		React.useEffect(() => {
		if (prevLocalToken.current && !localToken) {
		electron?.fetchDeviceToken?.();
		}

		prevLocalToken.current = localToken;
		}, [localToken]);
}		}

function useCreatePushSubscription(): () => Promise<void> {		function useCreatePushSubscription(): () => Promise<void> {
const publicKey = useSelector(state => state.pushApiPublicKey);		const publicKey = useSelector(state => state.pushApiPublicKey);

const dispatchActionPromise = useDispatchActionPromise();		const dispatchActionPromise = useDispatchActionPromise();
const callSetDeviceToken = useSetDeviceTokenFanout();		const callSetDeviceToken = useSetDeviceTokenFanout();
const staffCanSee = useStaffCanSee();		const staffCanSee = useStaffCanSee();
▲ Show 20 Lines • Show All 136 Lines • ▼ Show 20 Lines	const callback = (event: MessageEvent) => {
}		}
};		};

navigator.serviceWorker.addEventListener('message', callback);		navigator.serviceWorker.addEventListener('message', callback);
return () =>		return () =>
navigator.serviceWorker?.removeEventListener('message', callback);		navigator.serviceWorker?.removeEventListener('message', callback);
}, [dispatch, supported]);		}, [dispatch, supported]);

		// Handle invalid device token
		const localToken = useSelector(
		state => state.tunnelbrokerDeviceToken.localToken,
		);
		const prevLocalToken = React.useRef(localToken);
		React.useEffect(() => {
		if (
		!navigator.serviceWorker \|\|
		!supported \|\|
		Notification.permission !== 'granted'
		) {
		return;
		}

		if (prevLocalToken.current && !localToken) {
		void createPushSubscription();
		}

		prevLocalToken.current = localToken;
		}, [createPushSubscription, localToken, supported]);

return null;		return null;
}		}

export { PushNotificationsHandler, useCreatePushSubscription };		export { PushNotificationsHandler, useCreatePushSubscription };

[native_rust_library] avoid triggering backup upload before cleanupClosedPublicActions