[identity] Fix device list reorder for logged-out devices
ClosedPublic
Actions

Authored by bartek on Feb 14 2025, 3:35 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM905ba74129b5: [identity] Fix device list reorder for logged-out devices

Summary

Fix issue in ENG-10180.
The device list was not reordered due to early exit when data was missing.

Test Plan

TDD with unit test. The new unit test failed before the return statement was removed.
Verified that login heals the device list after previous primary device data was removed from DDB manually

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 14 2025, 3:35 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 14 2025, 3:35 PM

Harbormaster completed remote builds in B33522: Diff 47112.Feb 14 2025, 4:15 PM

bartek published this revision for review.Feb 14 2025, 5:45 PM

kamil accepted this revision.Feb 17 2025, 11:41 AM

This revision is now accepted and ready to land.Feb 17 2025, 11:41 AM

Closed by commit rCOMM905ba74129b5: [identity] Fix device list reorder for logged-out devices. · Explain WhyFeb 17 2025, 1:57 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM905ba74129b5: [identity] Fix device list reorder for logged-out devices.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

device_list.rs

20 lines

Diff 47124

View Options

services/identity/src/database/device_list.rs

[identity] Fix device list reorder for logged-out devicesClosedPublicActions