[backup] Don't display false-positive warn
ClosedPublic
Actions

Authored by bartek on Feb 14 2025, 3:44 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM8f84e77105b6: [backup] Don't display false-positive warn

Summary

Described in ENG-10179.
The warning is false-positive when limit is set because last_evaluated_key is present in that case.

Test Plan

Tested on staging, real world scenario we were encountering seems not to be reproducible on localstack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 14 2025, 3:44 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 14 2025, 3:44 PM

bartek published this revision for review.Feb 14 2025, 3:45 PM

Harbormaster completed remote builds in B33523: Diff 47113.Feb 14 2025, 4:28 PM

kamil accepted this revision.Feb 17 2025, 10:03 AM

This revision is now accepted and ready to land.Feb 17 2025, 10:03 AM

Closed by commit rCOMM8f84e77105b6: [backup] Don't display false-positive warn. · Explain WhyFeb 17 2025, 1:57 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8f84e77105b6: [backup] Don't display false-positive warn.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

database/

mod.rs

2 lines

Diff 47125

View Options

services/backup/src/database/mod.rs

[backup] Don't display false-positive warnClosedPublicActions