Paths

Table of Contentst

-
services/identity/src/
-
identity/
-
src/
-
client_service.rs
-
database/
-
device_list.rs

Differential D14379

[identity] Fix notif prekey verification
ClosedPublic
Actions

Authored by bartek on Feb 18 2025, 1:33 AM.

Details

Reviewers

kamil

Commits

rCOMMd59af1461a18: [identity] Fix notif prekey verification

Summary

Fixes ENG-10210.
Verifying notif prekey requires notif Olm account, which has a different signing public key. DeviceID is signing key only for content account.

Test Plan

Registered a device and explicitly printed out verification results
Pasted the values from DDB into unit test, using deviceKeyInfo.keyPayload.notificationIdentityPublicKeys.ed25519 as signing key.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 18 2025, 1:33 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 18 2025, 1:33 AM

bartek published this revision for review.Feb 18 2025, 1:40 AM

Harbormaster completed remote builds in B33534: Diff 47135.Feb 18 2025, 1:52 AM

kamil accepted this revision.Feb 18 2025, 2:45 AM

This revision is now accepted and ready to land.Feb 18 2025, 2:45 AM

Closed by commit rCOMMd59af1461a18: [identity] Fix notif prekey verification (authored by bartek). · Explain WhyFeb 20 2025, 6:40 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd59af1461a18: [identity] Fix notif prekey verification.

bartek mentioned this in D14392: [terraform] Bump staging Identity to 0.51.1.Feb 20 2025, 6:42 AM

bartek mentioned this in rCOMM24d01125df19: [terraform] Bump staging Identity to 0.51.1.Feb 20 2025, 6:54 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

5 lines

database/

device_list.rs

2 lines

Diff 47168

View Options

services/identity/src/client_service.rs

Show All 14 Lines
import type { MessageSentStatus } from '../types/tunnelbroker/message-to-device-request-status-types.js';		import type { MessageSentStatus } from '../types/tunnelbroker/message-to-device-request-status-types.js';
import type { MessageToDeviceRequest } from '../types/tunnelbroker/message-to-device-request-types.js';		import type { MessageToDeviceRequest } from '../types/tunnelbroker/message-to-device-request-types.js';
import type { MessageToTunnelbrokerRequest } from '../types/tunnelbroker/message-to-tunnelbroker-request-types.js';		import type { MessageToTunnelbrokerRequest } from '../types/tunnelbroker/message-to-tunnelbroker-request-types.js';
import {		import {
type TunnelbrokerMessage,		type TunnelbrokerMessage,
tunnelbrokerMessageTypes,		tunnelbrokerMessageTypes,
tunnelbrokerMessageValidator,		tunnelbrokerMessageValidator,
} from '../types/tunnelbroker/messages.js';		} from '../types/tunnelbroker/messages.js';
import type { TunnelbrokerAPNsNotif } from '../types/tunnelbroker/notif-types.js';		import type {
		TunnelbrokerAPNsNotif,
		TunnelbrokerFCMNotif,
		} from '../types/tunnelbroker/notif-types.js';
import type {		import type {
AnonymousInitializationMessage,		AnonymousInitializationMessage,
ConnectionInitializationMessage,		ConnectionInitializationMessage,
TunnelbrokerInitializationMessage,		TunnelbrokerInitializationMessage,
TunnelbrokerDeviceTypes,		TunnelbrokerDeviceTypes,
} from '../types/tunnelbroker/session-types.js';		} from '../types/tunnelbroker/session-types.js';
import type { Heartbeat } from '../types/websocket/heartbeat-types.js';		import type { Heartbeat } from '../types/websocket/heartbeat-types.js';
import { getConfig } from '../utils/config.js';		import { getConfig } from '../utils/config.js';
Show All 24 Lines	\| {
+connected: false,		+connected: false,
};		};

type TunnelbrokerContextType = {		type TunnelbrokerContextType = {
+sendMessage: (		+sendMessage: (
message: TunnelbrokerClientMessageToDevice,		message: TunnelbrokerClientMessageToDevice,
messageID: ?string,		messageID: ?string,
) => Promise<void>,		) => Promise<void>,
+sendNotif: (notif: TunnelbrokerAPNsNotif) => Promise<void>,		+sendNotif: (
		notif: TunnelbrokerAPNsNotif \| TunnelbrokerFCMNotif,
		) => Promise<void>,
+sendMessageToTunnelbroker: (payload: string) => Promise<void>,		+sendMessageToTunnelbroker: (payload: string) => Promise<void>,
+addListener: (listener: TunnelbrokerSocketListener) => void,		+addListener: (listener: TunnelbrokerSocketListener) => void,
+removeListener: (listener: TunnelbrokerSocketListener) => void,		+removeListener: (listener: TunnelbrokerSocketListener) => void,
+socketState: TunnelbrokerSocketState,		+socketState: TunnelbrokerSocketState,
+setUnauthorizedDeviceID: (unauthorizedDeviceID: ?string) => void,		+setUnauthorizedDeviceID: (unauthorizedDeviceID: ?string) => void,
};		};

const TunnelbrokerContext: React.Context<?TunnelbrokerContextType> =		const TunnelbrokerContext: React.Context<?TunnelbrokerContextType> =
▲ Show 20 Lines • Show All 238 Lines • ▼ Show 20 Lines	React.useEffect(() => {
createInitMessage,		createInitMessage,
socketState.connected,		socketState.connected,
]);		]);

const sendMessageToDeviceRequest: (		const sendMessageToDeviceRequest: (
request:		request:
\| MessageToDeviceRequest		\| MessageToDeviceRequest
\| MessageToTunnelbrokerRequest		\| MessageToTunnelbrokerRequest
\| TunnelbrokerAPNsNotif,		\| TunnelbrokerAPNsNotif
		\| TunnelbrokerFCMNotif,
) => Promise<void> = React.useCallback(		) => Promise<void> = React.useCallback(
request => {		request => {
return new Promise((resolve, reject) => {		return new Promise((resolve, reject) => {
const socketActive = socketState.connected && socket.current;		const socketActive = socketState.connected && socket.current;
if (!shouldBeClosed && !socketActive) {		if (!shouldBeClosed && !socketActive) {
throw new Error('Tunnelbroker not connected');		throw new Error('Tunnelbroker not connected');
}		}
promises.current[request.clientMessageID] = {		promises.current[request.clientMessageID] = {
▲ Show 20 Lines • Show All 152 Lines • Show Last 20 Lines