Page MenuHomePhabricator
Differential D14380

[identity] Better handle new flow users in v1 logout
ClosedPublic
Actions

Authored by bartek on Feb 18 2025, 1:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 6:26 PM
Unknown Object (File)
Sat, Mar 29, 8:05 PM
Unknown Object (File)
Sat, Mar 29, 10:52 AM
Unknown Object (File)
Mon, Mar 24, 12:58 PM
Unknown Object (File)
Mon, Mar 24, 6:01 AM
Unknown Object (File)
Mon, Mar 24, 1:34 AM
Unknown Object (File)
Sun, Mar 23, 5:12 PM
Unknown Object (File)
Mon, Mar 17, 9:45 PM
View All 35 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM635dfc954c2b: [identity] Better handle new flow users in v1 logout
Summary

Addresses 1 and 2a from ENG-10202.

  • For v2 flow primary device logout, display an error message
  • For v1 flow primary device logout, remove backup to future-proof restore flow (make sure it falls back to v1).
Test Plan

Tested on staging

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Feb 18 2025, 1:51 AM
bartek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 18 2025, 1:51 AM
Harbormaster failed remote builds in B33535: Diff 47136!Feb 18 2025, 2:17 AM
bartek updated this revision to Diff 47143.Feb 18 2025, 5:35 AM

Add backup service url to commtest config

bartek published this revision for review.Feb 18 2025, 6:44 AM
bartek added inline comments.
services/identity/src/grpc_services/authenticated.rs
398–401 ↗(On Diff #47143)

This can trigger alarms. Wondering if should lower it to warn.

kamil accepted this revision.Feb 19 2025, 2:34 AM
kamil added inline comments.
services/identity/src/grpc_services/authenticated.rs
398–401 ↗(On Diff #47143)

I would leave it as it is - we can lower if needed

1291 ↗(On Diff #47143)

should we reuse to reduce code duplication, e.g. verify_device_on_device_list?

This revision is now accepted and ready to land.Feb 19 2025, 2:34 AM
bartek added inline comments.Feb 20 2025, 6:19 AM
services/identity/src/grpc_services/authenticated.rs
1291 ↗(On Diff #47143)

Yes, good find

bartek updated this revision to Diff 47167.Feb 20 2025, 6:19 AM

Use get_current_device_list helper in other places

Harbormaster completed remote builds in B33555: Diff 47167.Feb 20 2025, 6:38 AM
Closed by commit rCOMM635dfc954c2b: [identity] Better handle new flow users in v1 logout (authored by bartek). · Explain WhyFeb 20 2025, 6:40 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM635dfc954c2b: [identity] Better handle new flow users in v1 logout.
bartek mentioned this in D14392: [terraform] Bump staging Identity to 0.51.1.Feb 20 2025, 6:42 AM
bartek mentioned this in rCOMM24d01125df19: [terraform] Bump staging Identity to 0.51.1.Feb 20 2025, 6:54 AM

Revision Contents
Changeset List

PathSize
services/
1 line
identity/
src/
grpc_services/
114 lines

Diff 47169

View Options

services/docker-compose.tests.yml

Show All 38 Lines
); );
function useInviteLinksActions( function useInviteLinksActions(
communityID: string, communityID: string,
inviteLink: ?InviteLink, inviteLink: ?InviteLink,
): { ): {
+error: ?string, +error: ?string,
+isLoading: boolean, +isLoading: boolean,
+isChanged: boolean,
+name: string, +name: string,
+setName: SetState<string>, +setName: SetState<string>,
+createOrUpdateInviteLink: () => mixed, +createOrUpdateInviteLink: () => mixed,
+disableInviteLink: () => mixed, +disableInviteLink: () => mixed,
} { } {
const [name, setName] = React.useState( const [name, setName] = React.useState(
inviteLink?.name ?? Math.random().toString(36).slice(-9), inviteLink?.name ?? Math.random().toString(36).slice(-9),
); );
▲ Show 20 Lines • Show All 47 Lines • ▼ Show 20 Lines): {
const isLoading = const isLoading =
createOrUpdatePublicLinkStatus === 'loading' || createOrUpdatePublicLinkStatus === 'loading' ||
disableInviteLinkStatus === 'loading'; disableInviteLinkStatus === 'loading';
return React.useMemo( return React.useMemo(
() => ({ () => ({
error, error,
isLoading, isLoading,
isChanged: name !== inviteLink?.name,
name, name,
setName, setName,
createOrUpdateInviteLink, createOrUpdateInviteLink,
disableInviteLink, disableInviteLink,
}), }),
[createOrUpdateInviteLink, disableInviteLink, error, isLoading, name], [
createOrUpdateInviteLink,
disableInviteLink,
error,
inviteLink?.name,
isLoading,
name,
],
); );
} }
const joinThreadLoadingStatusSelector = createLoadingStatusSelector( const joinThreadLoadingStatusSelector = createLoadingStatusSelector(
joinThreadActionTypes, joinThreadActionTypes,
); );
type AcceptInviteLinkParams = { type AcceptInviteLinkParams = {
▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines
View Options

services/identity/src/grpc_services/authenticated.rs

Show All 38 Lines
); );
function useInviteLinksActions( function useInviteLinksActions(
communityID: string, communityID: string,
inviteLink: ?InviteLink, inviteLink: ?InviteLink,
): { ): {
+error: ?string, +error: ?string,
+isLoading: boolean, +isLoading: boolean,
+isChanged: boolean,
+name: string, +name: string,
+setName: SetState<string>, +setName: SetState<string>,
+createOrUpdateInviteLink: () => mixed, +createOrUpdateInviteLink: () => mixed,
+disableInviteLink: () => mixed, +disableInviteLink: () => mixed,
} { } {
const [name, setName] = React.useState( const [name, setName] = React.useState(
inviteLink?.name ?? Math.random().toString(36).slice(-9), inviteLink?.name ?? Math.random().toString(36).slice(-9),
); );
▲ Show 20 Lines • Show All 47 Lines • ▼ Show 20 Lines): {
const isLoading = const isLoading =
createOrUpdatePublicLinkStatus === 'loading' || createOrUpdatePublicLinkStatus === 'loading' ||
disableInviteLinkStatus === 'loading'; disableInviteLinkStatus === 'loading';
return React.useMemo( return React.useMemo(
() => ({ () => ({
error, error,
isLoading, isLoading,
isChanged: name !== inviteLink?.name,
name, name,
setName, setName,
createOrUpdateInviteLink, createOrUpdateInviteLink,
disableInviteLink, disableInviteLink,
}), }),
[createOrUpdateInviteLink, disableInviteLink, error, isLoading, name], [
createOrUpdateInviteLink,
disableInviteLink,
error,
inviteLink?.name,
isLoading,
name,
],
); );
} }
const joinThreadLoadingStatusSelector = createLoadingStatusSelector( const joinThreadLoadingStatusSelector = createLoadingStatusSelector(
joinThreadActionTypes, joinThreadActionTypes,
); );
type AcceptInviteLinkParams = { type AcceptInviteLinkParams = {
▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines