Paths

Table of Contentst

-
lib/
-
hooks/
2/2
sidebar-hooks.js
2/2
thread-time.js
-
selectors/
2/2
chat-selectors.js
-
shared/messages/
-
messages/
2/2
add-members-message-spec.js
-
join-thread-message-spec.js
-
leave-thread-message-spec.js
-
message-spec.js
-
multimedia-message-spec.js
-
reaction-message-spec.js
-
remove-members-message-spec.js

[lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo
ClosedPublic
Actions

Authored by ashoat on Feb 25 2025, 12:19 AM.

Details

Reviewers

tomek
angelika

Commits

rCOMM40501edd21e2: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo

Summary

Previously we have two different callsites here, one that passed in RawMessageInfo and one that passed in MessageInfo.

There's no reason to maintain the behavior of passing in MessageInfo. It simplifies the code to standardize on RawMessageInfo, and also helps avoid unnecessary computation.

Test Plan

I used this patch that adds a bunch of logs and ran a Release build of the iOS app pointed at production on my physical iOS device. I confirmed that the logs indicated a limited (minimal) amount of fetches for last updated time and MessagePreview, and that things generally looked okay in the app

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 25 2025, 12:19 AM

ashoat added a child revision: D14400: [lib] Add numMessagesToFetch param to useFetchMessages.

Harbormaster completed remote builds in B33615: Diff 47235.Feb 25 2025, 12:53 AM

ashoat requested review of this revision.Feb 25 2025, 12:53 AM

tomek accepted this revision.Feb 25 2025, 2:20 AM

This revision is now accepted and ready to land.Feb 25 2025, 2:20 AM

Closed by commit rCOMM40501edd21e2: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo (authored by ashoat). · Explain WhyFeb 25 2025, 9:23 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM40501edd21e2: [lib] Simplify useGetLastUpdatedTimes to use RawMessageInfo.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

sidebar-hooks.js

6 lines

thread-time.js

11 lines

selectors/

chat-selectors.js

5 lines

shared/

messages/

add-members-message-spec.js

4 lines

join-thread-message-spec.js

4 lines

leave-thread-message-spec.js

4 lines

message-spec.js

2 lines

multimedia-message-spec.js

8 lines

reaction-message-spec.js

8 lines

remove-members-message-spec.js

5 lines

Diff 47275

View Options

lib/hooks/sidebar-hooks.js

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines	) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) {		if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented');		throw new Error('Register password user method unimplemented');
}		}
return identityClient.registerPasswordUser;		return identityClient.registerPasswordUser;
}		}
		function useIdentityPasswordRegisterReserved(): (
		varunAuthorUnsubmitted Done Inline Actions i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not actually intended to be dispatched with those action types varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
		usename: string,
		password: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedPasswordUser) {
		throw new Error('Register password user method unimplemented');
		}
		return identityClient.registerReservedPasswordUser;
		}
function useIdentityWalletRegister(): (		function useIdentityWalletRegister(): (
walletAddress: string,		walletAddress: string,
siweMessage: string,		siweMessage: string,
siweSignature: string,		siweSignature: string,
fid: ?string,		fid: ?string,
) => Promise<IdentityAuthResult> {		) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) {		if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented');		throw new Error('Register wallet user method unimplemented');
}		}
return identityClient.registerWalletUser;		return identityClient.registerWalletUser;
}		}
		function useIdentityWalletRegisterReserved(): (
		walletAddress: string,
		siweMessage: string,
		siweSignature: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedWalletUser) {
		throw new Error('Register wallet user method unimplemented');
		}
		return identityClient.registerReservedWalletUser;
		}

const identityGenerateNonceActionTypes = Object.freeze({		const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED',		started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS',		success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED',		failed: 'IDENTITY_GENERATE_NONCE_FAILED',
});		});
function useIdentityGenerateNonce(): () => Promise<string> {		function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines	export {
updateUserAvatar,		updateUserAvatar,
deleteAccountActionTypes,		deleteAccountActionTypes,
useDeleteAccount,		useDeleteAccount,
useDeleteDiscardedIdentityAccount,		useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes,		keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction,		keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes,		identityRegisterActionTypes,
useIdentityPasswordRegister,		useIdentityPasswordRegister,
		useIdentityPasswordRegisterReserved,
useIdentityWalletRegister,		useIdentityWalletRegister,
		useIdentityWalletRegisterReserved,
		varunAuthorUnsubmitted Done Inline Actions we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes,		identityGenerateNonceActionTypes,
useIdentityGenerateNonce,		useIdentityGenerateNonce,
};		};

View Options

lib/hooks/thread-time.js

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines	) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) {		if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented');		throw new Error('Register password user method unimplemented');
}		}
return identityClient.registerPasswordUser;		return identityClient.registerPasswordUser;
}		}
		function useIdentityPasswordRegisterReserved(): (
		varunAuthorUnsubmitted Done Inline Actions i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not actually intended to be dispatched with those action types varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
		usename: string,
		password: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedPasswordUser) {
		throw new Error('Register password user method unimplemented');
		}
		return identityClient.registerReservedPasswordUser;
		}
function useIdentityWalletRegister(): (		function useIdentityWalletRegister(): (
walletAddress: string,		walletAddress: string,
siweMessage: string,		siweMessage: string,
siweSignature: string,		siweSignature: string,
fid: ?string,		fid: ?string,
) => Promise<IdentityAuthResult> {		) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) {		if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented');		throw new Error('Register wallet user method unimplemented');
}		}
return identityClient.registerWalletUser;		return identityClient.registerWalletUser;
}		}
		function useIdentityWalletRegisterReserved(): (
		walletAddress: string,
		siweMessage: string,
		siweSignature: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedWalletUser) {
		throw new Error('Register wallet user method unimplemented');
		}
		return identityClient.registerReservedWalletUser;
		}

const identityGenerateNonceActionTypes = Object.freeze({		const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED',		started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS',		success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED',		failed: 'IDENTITY_GENERATE_NONCE_FAILED',
});		});
function useIdentityGenerateNonce(): () => Promise<string> {		function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines	export {
updateUserAvatar,		updateUserAvatar,
deleteAccountActionTypes,		deleteAccountActionTypes,
useDeleteAccount,		useDeleteAccount,
useDeleteDiscardedIdentityAccount,		useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes,		keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction,		keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes,		identityRegisterActionTypes,
useIdentityPasswordRegister,		useIdentityPasswordRegister,
		useIdentityPasswordRegisterReserved,
useIdentityWalletRegister,		useIdentityWalletRegister,
		useIdentityWalletRegisterReserved,
		varunAuthorUnsubmitted Done Inline Actions we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes,		identityGenerateNonceActionTypes,
useIdentityGenerateNonce,		useIdentityGenerateNonce,
};		};

View Options

lib/selectors/chat-selectors.js

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines	) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) {		if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented');		throw new Error('Register password user method unimplemented');
}		}
return identityClient.registerPasswordUser;		return identityClient.registerPasswordUser;
}		}
		function useIdentityPasswordRegisterReserved(): (
		varunAuthorUnsubmitted Done Inline Actions i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not actually intended to be dispatched with those action types varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
		usename: string,
		password: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedPasswordUser) {
		throw new Error('Register password user method unimplemented');
		}
		return identityClient.registerReservedPasswordUser;
		}
function useIdentityWalletRegister(): (		function useIdentityWalletRegister(): (
walletAddress: string,		walletAddress: string,
siweMessage: string,		siweMessage: string,
siweSignature: string,		siweSignature: string,
fid: ?string,		fid: ?string,
) => Promise<IdentityAuthResult> {		) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) {		if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented');		throw new Error('Register wallet user method unimplemented');
}		}
return identityClient.registerWalletUser;		return identityClient.registerWalletUser;
}		}
		function useIdentityWalletRegisterReserved(): (
		walletAddress: string,
		siweMessage: string,
		siweSignature: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedWalletUser) {
		throw new Error('Register wallet user method unimplemented');
		}
		return identityClient.registerReservedWalletUser;
		}

const identityGenerateNonceActionTypes = Object.freeze({		const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED',		started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS',		success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED',		failed: 'IDENTITY_GENERATE_NONCE_FAILED',
});		});
function useIdentityGenerateNonce(): () => Promise<string> {		function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines	export {
updateUserAvatar,		updateUserAvatar,
deleteAccountActionTypes,		deleteAccountActionTypes,
useDeleteAccount,		useDeleteAccount,
useDeleteDiscardedIdentityAccount,		useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes,		keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction,		keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes,		identityRegisterActionTypes,
useIdentityPasswordRegister,		useIdentityPasswordRegister,
		useIdentityPasswordRegisterReserved,
useIdentityWalletRegister,		useIdentityWalletRegister,
		useIdentityWalletRegisterReserved,
		varunAuthorUnsubmitted Done Inline Actions we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes,		identityGenerateNonceActionTypes,
useIdentityGenerateNonce,		useIdentityGenerateNonce,
};		};

View Options

lib/shared/messages/add-members-message-spec.js

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines	) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerPasswordUser) {		if (!identityClient.registerPasswordUser) {
throw new Error('Register password user method unimplemented');		throw new Error('Register password user method unimplemented');
}		}
return identityClient.registerPasswordUser;		return identityClient.registerPasswordUser;
}		}
		function useIdentityPasswordRegisterReserved(): (
		varunAuthorUnsubmitted Done Inline Actions i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not actually intended to be dispatched with those action types varun: i'll separate these hooks from `identityRegisterActionTypes` a little, because they're not…
		usename: string,
		password: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedPasswordUser) {
		throw new Error('Register password user method unimplemented');
		}
		return identityClient.registerReservedPasswordUser;
		}
function useIdentityWalletRegister(): (		function useIdentityWalletRegister(): (
walletAddress: string,		walletAddress: string,
siweMessage: string,		siweMessage: string,
siweSignature: string,		siweSignature: string,
fid: ?string,		fid: ?string,
) => Promise<IdentityAuthResult> {		) => Promise<IdentityAuthResult> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
const identityClient = client?.identityClient;		const identityClient = client?.identityClient;
invariant(identityClient, 'Identity client should be set');		invariant(identityClient, 'Identity client should be set');
if (!identityClient.registerWalletUser) {		if (!identityClient.registerWalletUser) {
throw new Error('Register wallet user method unimplemented');		throw new Error('Register wallet user method unimplemented');
}		}
return identityClient.registerWalletUser;		return identityClient.registerWalletUser;
}		}
		function useIdentityWalletRegisterReserved(): (
		walletAddress: string,
		siweMessage: string,
		siweSignature: string,
		keyserverMessage: string,
		keyserverSignature: string,
		) => Promise<IdentityAuthResult> {
		const client = React.useContext(IdentityClientContext);
		const identityClient = client?.identityClient;
		invariant(identityClient, 'Identity client should be set');
		if (!identityClient.registerReservedWalletUser) {
		throw new Error('Register wallet user method unimplemented');
		}
		return identityClient.registerReservedWalletUser;
		}

const identityGenerateNonceActionTypes = Object.freeze({		const identityGenerateNonceActionTypes = Object.freeze({
started: 'IDENTITY_GENERATE_NONCE_STARTED',		started: 'IDENTITY_GENERATE_NONCE_STARTED',
success: 'IDENTITY_GENERATE_NONCE_SUCCESS',		success: 'IDENTITY_GENERATE_NONCE_SUCCESS',
failed: 'IDENTITY_GENERATE_NONCE_FAILED',		failed: 'IDENTITY_GENERATE_NONCE_FAILED',
});		});
function useIdentityGenerateNonce(): () => Promise<string> {		function useIdentityGenerateNonce(): () => Promise<string> {
const client = React.useContext(IdentityClientContext);		const client = React.useContext(IdentityClientContext);
▲ Show 20 Lines • Show All 401 Lines • ▼ Show 20 Lines	export {
updateUserAvatar,		updateUserAvatar,
deleteAccountActionTypes,		deleteAccountActionTypes,
useDeleteAccount,		useDeleteAccount,
useDeleteDiscardedIdentityAccount,		useDeleteDiscardedIdentityAccount,
keyserverAuthActionTypes,		keyserverAuthActionTypes,
keyserverAuth as keyserverAuthRawAction,		keyserverAuth as keyserverAuthRawAction,
identityRegisterActionTypes,		identityRegisterActionTypes,
useIdentityPasswordRegister,		useIdentityPasswordRegister,
		useIdentityPasswordRegisterReserved,
useIdentityWalletRegister,		useIdentityWalletRegister,
		useIdentityWalletRegisterReserved,
		varunAuthorUnsubmitted Done Inline Actions we actually don't need to expose these new hooks publicly, since they'll only be called by the identity login hooks varun: we actually don't need to expose these new hooks publicly, since they'll only be called by the…
identityGenerateNonceActionTypes,		identityGenerateNonceActionTypes,
useIdentityGenerateNonce,		useIdentityGenerateNonce,
};		};