[native] Fall back to v1 login after `use_v1_flow` response
ClosedPublic
Actions

Authored by tomek on Feb 25 2025, 1:52 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM0795c4d41308: [native] Fall back to v1 login after `use_v1_flow` response

Summary

When a user has a backup but their device list doesn't have a signature, try to restore an account, and if that fails, fall back to the v1 login.

https://linear.app/comm/issue/ENG-10220/restore-flow-consider-adding-2nd-fallback-to-v1

Test Plan

Tested for password and SIWE users. Create an account, delete a signature from the most recent device list. Try to restore - this fails without this diff, but after this diff it succeeds because the v1 fallback is used.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 25 2025, 1:52 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 25 2025, 1:52 PM

Harbormaster completed remote builds in B33630: Diff 47272.Feb 25 2025, 3:45 PM

tomek requested review of this revision.Feb 25 2025, 3:45 PM

ashoat added inline comments.Feb 25 2025, 5:07 PM

native/account/restore-backup-screen.react.js
56–68 ↗	(On Diff #47272)	Where did you get this logic from? Wondering if it was copy-pasted from somewhere that could be factored out instead

bartek accepted this revision.Feb 26 2025, 1:46 PM

This revision is now accepted and ready to land.Feb 26 2025, 1:46 PM

tomek added inline comments.Feb 26 2025, 4:16 PM

native/account/restore-backup-screen.react.js
56–68 ↗	(On Diff #47272)	This logic is taken from two places and merged, so it isn't obvious how to reuse it. I can try creating a hook and then using it in all three places - will see how it looks like.