Paths

Table of Contentst

Differential D14415

[lib][native] Respect login flow in useLogIn and useIdentityLogOut
ClosedPublic
Actions

Authored by bartek on Feb 27 2025, 10:00 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

tomek
kamil

Commits

rCOMMb218da0df38f: [lib][native] Respect login flow in useLogIn and useIdentityLogOut

Summary

Addresses ENG-10249
Updated useLogIn and useIdentityLogOut hooks to accept login/logout type as a param, to call correct RPCs.

Test Plan

Made keyserver auth always fail (hardcode throw)
Verified that correct RPC is called: v1 in legacy logout and fallback, primary device logout during restore flow
- Printed out log out type next to RPC call
- Observed AWS Console - service logs and device list updates in dynamodb

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 27 2025, 10:00 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2025, 10:00 AM

Rebase

bartek published this revision for review.Feb 27 2025, 11:03 AM

tomek accepted this revision.Feb 27 2025, 4:57 PM

This revision is now accepted and ready to land.Feb 27 2025, 4:57 PM

This revision was landed with ongoing or failed builds.Feb 28 2025, 11:27 AM

Closed by commit rCOMMb218da0df38f: [lib][native] Respect login flow in useLogIn and useIdentityLogOut. · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb218da0df38f: [lib][native] Respect login flow in useLogIn and useIdentityLogOut.

Revision Contents
Changeset List

Path

Size

lib/

actions/

user-actions.js

33 lines

hooks/

22 lines

native/

account/

2 lines

Diff 47301

lib/actions/user-actions.js

Loading...

lib/hooks/login-hooks.js

Loading...

native/account/restore.js

Loading...