[lib] Handle user_not_found returned by GetKeyserverKeys RPC
ClosedPublic
Actions

Authored by bartek on Feb 27 2025, 7:58 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC

Summary

Address ENG-10261.
Replaced user_not_found with custom error message that doesn't trigger the "Invalid username or password" alert.

Test Plan

Mocked GetKeyserverKeys to always throw new Error('user_not_found')
Before: invalid credentials alert was shown
After: unknown error modal is shown

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Feb 27 2025, 7:58 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 27 2025, 7:58 AM

bartek published this revision for review.Feb 27 2025, 8:30 AM

tomek accepted this revision.Feb 27 2025, 9:00 AM

tomek added inline comments.

lib/keyserver-conn/keyserver-auth.js
158 ↗	(On Diff #47293)	Should we show a different alert in such a case?

This revision is now accepted and ready to land.Feb 27 2025, 9:00 AM

bartek added inline comments.Feb 28 2025, 12:56 AM

lib/keyserver-conn/keyserver-auth.js
158 ↗	(On Diff #47293)	This might be worth considering when implementing support for multiple keyservers. Now, this is a case only for authoritative keyserver auth, so I don't think UI changes are necessary.

This revision was landed with ongoing or failed builds.Feb 28 2025, 3:27 AM

Closed by commit rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM6c919da7b92b: [lib] Handle user_not_found returned by GetKeyserverKeys RPC.

Revision Contents
Changeset List

Path

Size

lib/

keyserver-conn/

keyserver-auth.js

6 lines

Diff 47302

View Options

lib/keyserver-conn/keyserver-auth.js

	locals {			locals {
	identity_service_image_tag = local.is_staging ? "0.22-staging" : "0.18"			identity_service_image_tag = local.is_staging ? "0.23-staging" : "0.18"
	identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"			identity_service_server_image = "commapp/identity-server:${local.identity_service_image_tag}"
	identity_service_container_name = "identity-server"			identity_service_container_name = "identity-server"

	# Port that the container is listening on			# Port that the container is listening on
	identity_service_container_grpc_port = 50054			identity_service_container_grpc_port = 50054
	identity_sc_port_name = "identity-service-ecs-grpc"			identity_sc_port_name = "identity-service-ecs-grpc"
	identity_sc_dns_name = "identity-service"			identity_sc_dns_name = "identity-service"

	▲ Show 20 Lines • Show All 296 Lines • Show Last 20 Lines

[lib] Handle user_not_found returned by GetKeyserverKeys RPCClosedPublicActions