[native] Remove dangling device after QR auth failure
ClosedPublic
Actions

Authored by bartek on Mar 6 2025, 12:50 AM.

Details

Reviewers

tomek
kamil
ashoat

Commits

rCOMMb322cf848bb5: [native] Remove dangling device after QR auth failure

Summary

Address ENG-10309.
Try reverting device list update after the process failed at a later point.

Test Plan

Replaced await sendDeviceListUpdateSuccessMessage() with throw new Error('foo')
After alert is shown, verified that:
- No new device is present on the Linked Devices screen
- Checked DynamoDB - two device list updates are present: the first update added a new device and the second update removed it. Before this diff, only the former update was present, resulting in dangling device on the list.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mar 6 2025, 12:50 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMar 6 2025, 12:50 AM

Harbormaster failed remote builds in B33688: Diff 47365!Mar 6 2025, 1:05 AM

bartek published this revision for review.Mar 6 2025, 1:26 AM

bartek added inline comments.

native/account/qr-auth/primary-device-qr-auth-context-provider.js
196–199 ↗	(On Diff #47365)	Perhaps I should wrap it with `ignorePromiseRejections`? Just in case this call fails too

ashoat accepted this revision.Mar 6 2025, 8:10 AM

ashoat added inline comments.

native/account/qr-auth/primary-device-qr-auth-context-provider.js
196–199 ↗	(On Diff #47365)	Doesn’t hurt

This revision is now accepted and ready to land.Mar 6 2025, 8:10 AM

Wrap in ignorePromiseRejections

Harbormaster failed remote builds in B33691: Diff 47368!Mar 7 2025, 2:00 AM

This revision was landed with ongoing or failed builds.Mar 14 2025, 1:58 AM

Closed by commit rCOMMb322cf848bb5: [native] Remove dangling device after QR auth failure (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMb322cf848bb5: [native] Remove dangling device after QR auth failure.

Revision Contents
Changeset List

Path

Size

native/

account/

qr-auth/

primary-device-qr-auth-context-provider.js

21 lines

Diff 47404

View Options

native/account/qr-auth/primary-device-qr-auth-context-provider.js

Show All 38 Lines	tracing::error!(
errorType = error_types::HTTP_LOG,		errorType = error_types::HTTP_LOG,
"Backup service failed to delete user data: {} - {}",		"Backup service failed to delete user data: {} - {}",
response_status,		response_status,
response_body,		response_body,
)		)
}		}
Ok(())		Ok(())
}		}

		pub async fn user_has_backup(
		user_identifier: &str,
		) -> Result<bool, crate::error::Error> {
		let path = format!("/backups/latest/{user_identifier}/backup_info");
		let url = CONFIG
		.backup_service_url
		.join(&path)
		.expect("failed to construct backup service URL");

		let client = reqwest::Client::builder().build()?;
		let response = client.get(url).send().await?;

		use http::StatusCode;
		match response.status() {
		StatusCode::OK => Ok(true), // Backup service returned backup info
		StatusCode::NOT_FOUND => Ok(false), // Backup service returned BackupError::NoBackup
		StatusCode::BAD_REQUEST => {
		// Identity has no user with given UserIdentifier
		Err(crate::error::Error::MissingItem)
		}
		response_status => {
		let response_body = response
		.text()
		.await
		.unwrap_or("[failed to get response text]".to_string());
		tracing::error!(
		errorType = error_types::HTTP_LOG,
		"Backup service failed to get latest backup info: {} - {}",
		response_status,
		response_body,
		);
		Err(
		tonic::Status::aborted(tonic_status_messages::UNEXPECTED_ERROR).into(),
		)
		}
		}
		}

[native] Remove dangling device after QR auth failureClosedPublicActions