Page MenuHomePhabricator
Differential D14435

[lib] Handle Farcaster mutuals only on a primary device
ClosedPublic
Actions

Authored by tomek on Mar 10 2025, 6:29 AM.
Tags
None
Referenced Files
F5771323: D14435.diff
Mon, Apr 14, 9:10 PM
Unknown Object (File)
Sat, Apr 12, 5:14 AM
Unknown Object (File)
Thu, Apr 10, 9:28 AM
Unknown Object (File)
Thu, Apr 10, 7:00 AM
Unknown Object (File)
Thu, Apr 10, 5:12 AM
Unknown Object (File)
Thu, Apr 10, 4:07 AM
Unknown Object (File)
Thu, Apr 10, 3:13 AM
Unknown Object (File)
Thu, Apr 10, 2:03 AM
View All 43 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM79628e02117a: [lib] Handle Farcaster mutuals only on a primary device
Summary

Check if a device is primary before creating relationships and threads.

https://linear.app/comm/issue/ENG-10350/received-ignoring-operation-because-it-is-invalid-logs-in-production

Test Plan

Flow. Haven't tested it - the change looks quite safe, and I'm not sure how to test that on a simulator.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mar 10 2025, 6:29 AM
tomek updated this revision to Diff 47380.Mar 10 2025, 6:35 AM

Move check earlier

Harbormaster failed remote builds in B33702: Diff 47379!Mar 10 2025, 6:45 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mar 10 2025, 6:48 AM
Harbormaster failed remote builds in B33703: Diff 47380!
tomek requested review of this revision.Mar 11 2025, 2:47 AM
ashoat accepted this revision.Mar 11 2025, 6:22 AM
This revision is now accepted and ready to land.Mar 11 2025, 6:22 AM
tomek updated this revision to Diff 47383.Mar 12 2025, 3:26 AM

Rebase

Harbormaster failed remote builds in B33705: Diff 47383!Mar 12 2025, 3:41 AM
tomek updated this revision to Diff 47385.Mar 12 2025, 5:47 AM

Rebase

Harbormaster completed remote builds in B33707: Diff 47385.Mar 12 2025, 6:06 AM
Closed by commit rCOMM79628e02117a: [lib] Handle Farcaster mutuals only on a primary device (authored by tomek). · Explain WhyMar 13 2025, 8:03 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM79628e02117a: [lib] Handle Farcaster mutuals only on a primary device.

Revision Contents
Changeset List

PathSize
lib/
components/
8 lines

Diff 47395

View Options

lib/components/farcaster-data-handler.react.js

Show First 20 Lines • Show All 284 Lines • ▼ Show 20 Lines tShape<DMRemoveMembersOperation>({
threadID: t.String, threadID: t.String,
removedUserIDs: t.list(tUserID), removedUserIDs: t.list(tUserID),
}); });
export type DMThreadSettingsChanges = { export type DMThreadSettingsChanges = {
+name?: string, +name?: string,
+description?: string, +description?: string,
+color?: string, +color?: string,
+avatar?: ClientAvatar, +avatar?: ClientAvatar | null,
}; };
export type DMChangeThreadSettingsOperation = $ReadOnly<{ export type DMChangeThreadSettingsOperation = $ReadOnly<{
+type: 'change_thread_settings', +type: 'change_thread_settings',
+threadID: string, +threadID: string,
+editorID: string, +editorID: string,
+time: number, +time: number,
+changes: DMThreadSettingsChanges, +changes: DMThreadSettingsChanges,
▲ Show 20 Lines • Show All 137 Lines • Show Last 20 Lines