Page MenuHomePhabricator
Differential D14435

[lib] Handle Farcaster mutuals only on a primary device
ClosedPublic
Actions

Authored by tomek on Mon, Mar 10, 6:29 AM.
Tags
None
Referenced Files
F5026682: D14435.id47385.diff
Mon, Mar 24, 4:00 PM
Unknown Object (File)
Sun, Mar 23, 2:16 PM
Unknown Object (File)
Sat, Mar 22, 1:26 PM
Unknown Object (File)
Fri, Mar 21, 9:40 AM
Unknown Object (File)
Thu, Mar 20, 7:13 PM
Unknown Object (File)
Thu, Mar 20, 1:16 PM
Unknown Object (File)
Thu, Mar 20, 10:59 AM
Unknown Object (File)
Wed, Mar 19, 11:12 PM
View All 29 Files
Subscribers
None

Details

Reviewers
kamil
ashoat
Commits
rCOMM79628e02117a: [lib] Handle Farcaster mutuals only on a primary device
Summary

Check if a device is primary before creating relationships and threads.

https://linear.app/comm/issue/ENG-10350/received-ignoring-operation-because-it-is-invalid-logs-in-production

Test Plan

Flow. Haven't tested it - the change looks quite safe, and I'm not sure how to test that on a simulator.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mon, Mar 10, 6:29 AM
tomek updated this revision to Diff 47380.Mon, Mar 10, 6:35 AM

Move check earlier

Harbormaster failed remote builds in B33702: Diff 47379!Mon, Mar 10, 6:45 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Mon, Mar 10, 6:48 AM
Harbormaster failed remote builds in B33703: Diff 47380!
tomek requested review of this revision.Tue, Mar 11, 2:47 AM
ashoat accepted this revision.Tue, Mar 11, 6:22 AM
This revision is now accepted and ready to land.Tue, Mar 11, 6:22 AM
tomek updated this revision to Diff 47383.Wed, Mar 12, 3:26 AM

Rebase

Harbormaster failed remote builds in B33705: Diff 47383!Wed, Mar 12, 3:41 AM
tomek updated this revision to Diff 47385.Wed, Mar 12, 5:47 AM

Rebase

Harbormaster completed remote builds in B33707: Diff 47385.Wed, Mar 12, 6:06 AM
Closed by commit rCOMM79628e02117a: [lib] Handle Farcaster mutuals only on a primary device (authored by tomek). · Explain WhyThu, Mar 13, 8:03 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM79628e02117a: [lib] Handle Farcaster mutuals only on a primary device.

Revision Contents
Changeset List

PathSize
lib/
components/
8 lines

Diff 47395

View Options

lib/components/farcaster-data-handler.react.js

Loading...