Differential D14513

[identity] Fix retrying OTK upload transaction
ClosedPublic
Actions

Authored by bartek on Apr 2 2025, 12:50 PM.

Details

Reviewers

kamil

Commits

rCOMM8b0b50263e18: [identity] Fix retrying OTK upload transaction

Summary

Context in ENG-10490.
For OTK retrieval we do retry on ConditionalCheckFailed, but we didn't when uploading keys.

Test Plan

Localstack stress testing (concurrent OTK get and upload requests), will also test on staging

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Apr 2 2025, 12:50 PM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 2 2025, 12:50 PM

Harbormaster completed remote builds in B33867: Diff 47616.Apr 2 2025, 1:09 PM

bartek published this revision for review.Apr 2 2025, 2:28 PM

kamil accepted this revision.Apr 2 2025, 2:31 PM

This revision is now accepted and ready to land.Apr 2 2025, 2:31 PM

Closed by commit rCOMM8b0b50263e18: [identity] Fix retrying OTK upload transaction. · Explain WhyApr 3 2025, 7:51 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM8b0b50263e18: [identity] Fix retrying OTK upload transaction.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

database/

one_time_keys.rs

7 lines

Diff 47619

View Options

services/identity/src/database/one_time_keys.rs

[identity] Fix retrying OTK upload transactionClosedPublicActions