Paths

Table of Contentst

[tunnelbroker] bump `web-push` version
ClosedPublic
Actions

Authored by kamil on Apr 9 2025, 9:23 AM.

Details

Reviewers

bartek
tomek

Commits

rCOMM4fff7ca27039: [tunnelbroker] bump `web-push` version

Summary

Doing this a potential fix for ENG-10501. It does not have a fix for the issue but it has improved logging.

Test Plan

Deployed TB on staging and tested notifs on Chrome, Safari and Firefox.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 9 2025, 9:23 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 9 2025, 9:23 AM

kamil published this revision for review.Apr 9 2025, 9:36 AM

kamil added inline comments.

services/tunnelbroker/src/notifs/web_push/mod.rs
32 ↗	(On Diff #47708)	The new implementation is doing `Base64UrlSafeNoPadding` by default, see here
60 ↗	(On Diff #47708)	In the new API, there isn't any way of adding `_err` to Error

Harbormaster completed remote builds in B33928: Diff 47708.Apr 9 2025, 9:41 AM

tomek accepted this revision.Apr 9 2025, 10:18 AM

This revision is now accepted and ready to land.Apr 9 2025, 10:18 AM

Closed by commit rCOMM4fff7ca27039: [tunnelbroker] bump `web-push` version. · Explain WhyApr 9 2025, 10:48 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4fff7ca27039: [tunnelbroker] bump `web-push` version.

kamil mentioned this in D14559: [terraform] bump staging Tunnelbroker to 0.18.4.Apr 9 2025, 11:00 AM

kamil mentioned this in rCOMM8832665bb4fe: [terraform] bump staging Tunnelbroker to 0.18.4.Apr 9 2025, 11:27 AM

kamil mentioned this in D14587: [terraform] bump prod Tunnelbroker to 0.18.4.Apr 22 2025, 9:00 AM

kamil mentioned this in rCOMMa57ac33f914b: [terraform] bump prod Tunnelbroker to 0.18.4.Apr 22 2025, 9:46 AM

Revision Contents
Changeset List

Path

Size

Cargo.lock

services/

tunnelbroker/

Cargo.toml

2 lines

src/

notifs/

web_push/

mod.rs

10 lines

websockets/

session.rs

3 lines

Diff 47709

View Options

Cargo.lock

View Options

services/tunnelbroker/Cargo.toml

View Options

services/tunnelbroker/src/notifs/web_push/mod.rs

View Options

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] bump `web-push` versionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47709

Cargo.lock

services/tunnelbroker/Cargo.toml

services/tunnelbroker/src/notifs/web_push/mod.rs

services/tunnelbroker/src/websockets/session.rs

[tunnelbroker] bump `web-push` version
ClosedPublic
Actions

Revision Contents
Changeset List