[native][SQLite] add logging to errors
ClosedPublic
Actions

Authored by kamil on Apr 10 2025, 9:52 AM.

Details

Reviewers

tomek
bartek

Commits

rCOMM0db8526f1c97: [native][SQLite] add logging to errors

Summary

ENG-10481.

I searched through all errors thrown onthe native side and added logging where needed

Test Plan

Build native, build WASM

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Apr 10 2025, 9:52 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptApr 10 2025, 9:52 AM

kamil published this revision for review.Apr 10 2025, 9:52 AM

kamil edited the summary of this revision. (Show Details)

bartek accepted this revision.Apr 10 2025, 9:59 AM

This revision is now accepted and ready to land.Apr 10 2025, 9:59 AM

Harbormaster completed remote builds in B33948: Diff 47730.Apr 10 2025, 10:10 AM

Closed by commit rCOMM0db8526f1c97: [native][SQLite] add logging to errors. · Explain WhyApr 10 2025, 10:11 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0db8526f1c97: [native][SQLite] add logging to errors.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

NativeSQLiteConnectionManager.cpp

26 lines

SQLiteConnectionManager.cpp

8 lines

SQLiteQueryExecutor.cpp

46 lines

entities/

EntityQueryHelpers.h

10 lines

SQLiteStatementWrapper.cpp

4 lines

NativeModules/

CommCoreModule.cpp

15 lines

Tools/

WorkerThread.cpp

6 lines

web/

shared-worker/

_generated/

comm_query_executor.wasm

Diff 47732

View Options

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

View Options

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteStatementWrapper.cpp

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

View Options

native/cpp/CommonCpp/Tools/WorkerThread.cpp

View Options

web/shared-worker/_generated/comm_query_executor.wasm

[native][SQLite] add logging to errorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47732

native/cpp/CommonCpp/DatabaseManagers/NativeSQLiteConnectionManager.cpp

native/cpp/CommonCpp/DatabaseManagers/SQLiteConnectionManager.cpp

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

native/cpp/CommonCpp/DatabaseManagers/entities/SQLiteStatementWrapper.cpp

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/Tools/WorkerThread.cpp

web/shared-worker/_generated/comm_query_executor.wasm

[native][SQLite] add logging to errors
ClosedPublic
Actions

Revision Contents
Changeset List