Differential D14568

[native] Fetch platform details during restore flow
ClosedPublic
Actions

Authored by bartek on Fri, Apr 11, 3:30 AM.

Details

Reviewers

kamil

Commits

rCOMMbf90254c736c: [native] Fetch platform details during restore flow

Summary

Fixes ENG-10525.

Test Plan

Created a dummy component with auxUserStore selectors for own userID and console.log changes. Right after restore, device list and platform details are up to date and match identity.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Fri, Apr 11, 3:30 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Apr 11, 3:30 AM

bartek retitled this revision from [native] Fetch platform details during restoe flow to [native] Fetch platform details during restore flow.Fri, Apr 11, 3:33 AM

bartek published this revision for review.Fri, Apr 11, 3:39 AM

Harbormaster completed remote builds in B33965: Diff 47750.Fri, Apr 11, 3:48 AM

kamil accepted this revision.Mon, Apr 14, 1:50 AM

kamil added inline comments.

native/account/restore.js
141–146 ↗	(On Diff #47750)	Do we need it now?

This revision is now accepted and ready to land.Mon, Apr 14, 1:50 AM

bartek added inline comments.Mon, Apr 14, 3:07 AM

native/account/restore.js
141–146 ↗	(On Diff #47750)	No, we don't need it anymore

Remove redundant code

Harbormaster completed remote builds in B33975: Diff 47761.Mon, Apr 14, 3:28 AM

Closed by commit rCOMMbf90254c736c: [native] Fetch platform details during restore flow (authored by bartek). · Explain WhyMon, Apr 14, 4:39 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMbf90254c736c: [native] Fetch platform details during restore flow.

Revision Contents
Changeset List

Path

Size

native/

account/

restore.js

24 lines

identity-service/

identity-service-context-provider.react.js

82 lines

Diff 47765

View Options

native/account/restore.js

Show First 20 Lines • Show All 2,327 Lines • ▼ Show 20 Lines	OlmPersistSession persistSession = {
it->first,		it->first,
std::string(it->second.buffer.begin(), it->second.buffer.end()),		std::string(it->second.buffer.begin(), it->second.buffer.end()),
it->second.version};		it->second.version};

this->storeOlmPersistSession(persistSession);		this->storeOlmPersistSession(persistSession);
}		}
}		}

void SQLiteQueryExecutor::setNotifyToken(std::string token) const {
this->setMetadata("notify_token", token);
}

void SQLiteQueryExecutor::clearNotifyToken() const {
this->clearMetadata("notify_token");
}

void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {		void SQLiteQueryExecutor::stampSQLiteDBUserID(std::string userID) const {
this->setMetadata("current_user_id", userID);		this->setMetadata("current_user_id", userID);
}		}

std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {		std::string SQLiteQueryExecutor::getSQLiteStampedUserID() const {
return this->getMetadata("current_user_id");		return this->getMetadata("current_user_id");
}		}

▲ Show 20 Lines • Show All 919 Lines • Show Last 20 Lines