Paths

Table of Contentst

Differential D14686

[backup] Add config option to keep old backups
ClosedPublic
Actions

Authored by bartek on May 12 2025, 11:20 AM.

Details

Reviewers

kamil

Commits

rCOMMacc11da1b817: [backup] Add config option to keep old backups

Summary

Address ENG-5278.
Added a boolean to disable removal of old backups. This is more flexible than hardcoding behavior and/or removing existing cleanup code which might be useful in the future.

Test Plan

Confirmed that old backups are no longer removed unless --remove-old-backups CLI flag is set

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 12 2025, 11:20 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 12 2025, 11:20 AM

Harbormaster failed remote builds in B34148: Diff 48041!May 12 2025, 11:46 AM

Update Commtest config

Harbormaster completed remote builds in B34150: Diff 48043.May 12 2025, 1:07 PM

bartek published this revision for review.May 12 2025, 1:13 PM

kamil accepted this revision.May 14 2025, 11:11 AM

This revision is now accepted and ready to land.May 14 2025, 11:11 AM

Closed by commit rCOMMacc11da1b817: [backup] Add config option to keep old backups. · Explain WhyMay 16 2025, 1:35 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMacc11da1b817: [backup] Add config option to keep old backups.

Revision Contents
Changeset List

Path

Size

services/

backup/

src/

config.rs

3 lines

database/

mod.rs

11 lines

docker-compose.tests.yml

1 line

Diff 48109

View Options

services/backup/src/config.rs

View Options

services/backup/src/database/mod.rs

View Options

services/docker-compose.tests.yml

[backup] Add config option to keep old backupsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48109

services/backup/src/config.rs

services/backup/src/database/mod.rs

services/docker-compose.tests.yml

[backup] Add config option to keep old backups
ClosedPublic
Actions

Revision Contents
Changeset List