Differential D14688

[lib] fix `fullStateSyncActionType` logic
ClosedPublic
Actions

Authored by kamil on May 12 2025, 1:13 PM.

Details

Reviewers

tomek

Commits

rCOMMa60bbbebe8bb: [lib] fix `fullStateSyncActionType` logic

Summary

ENG-10761

Test Plan

Simulate state sync and check if there are no errors in the app (while having thick threads created)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.May 12 2025, 1:13 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 12 2025, 1:13 PM

kamil edited the test plan for this revision. (Show Details)May 12 2025, 1:14 PM

Harbormaster completed remote builds in B34152: Diff 48045.May 12 2025, 1:33 PM

kamil requested review of this revision.May 12 2025, 1:33 PM

tomek accepted this revision.May 12 2025, 2:16 PM

tomek added inline comments.

lib/reducers/integrity-reducer.js
49–51 ↗	(On Diff #48045)	I think we can remove this code

This revision is now accepted and ready to land.May 12 2025, 2:16 PM

kamil added inline comments.May 12 2025, 3:52 PM

lib/reducers/integrity-reducer.js
46–47 ↗	(On Diff #48045)	I took it from D11313 and added here to make it less confusing

rreview changes

Harbormaster completed remote builds in B34156: Diff 48050.May 12 2025, 4:13 PM

Closed by commit rCOMMa60bbbebe8bb: [lib] fix `fullStateSyncActionType` logic. · Explain WhyMay 13 2025, 8:43 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa60bbbebe8bb: [lib] fix `fullStateSyncActionType` logic.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

integrity-reducer.js

10 lines

thread-reducer.js

4 lines

Diff 48051

View Options

lib/reducers/integrity-reducer.js