[lib] Refactor fullStateSyncActionType in reducers
ClosedPublic
Actions

Authored by inka on Mar 13 2024, 8:59 AM.

Details

Reviewers

michal
ginsu
kamil

Commits

rCOMMb425f8ee17b1: [lib] Refactor fullStateSyncActionType in reducers

Summary

issue: ENG-6484
fullStateSyncActionType always concerns only one keyserver. It is a "specific" action. It has a keyserverID in the payload.

reduceIntegrityStore -> we should not clear the whole store, only remove the threads related to this keyserver

reduceThreadInfos -> we shouldn't remove all threads, only the threads related to this keyserver

reduceCurrentUserInfo -> it should not change currentUserInfo for clients not relying on authoritative keyserver

reduceUserInfos -> it shouldn't be removing user infos for clients not relying on authoritative keyserver

Test Plan

tested that only threads related to the keyserver the action concerns are removed from thread store, and only their hashes are removed from integrity store. Checked that for clients relying on authoritative keyserver currentUserInfo and userStore are being changed

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.Mar 13 2024, 8:59 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 13 2024, 8:59 AM

Harbormaster completed remote builds in B27483: Diff 38040.Mar 13 2024, 9:15 AM

inka requested review of this revision.Mar 13 2024, 9:15 AM

inka added inline comments.Mar 13 2024, 9:23 AM

lib/reducers/user-reducer.js
111–113 ↗	(On Diff #38040)	Flow gets confused if I merge this if with the one above
285–287 ↗	(On Diff #38040)	Flow gets confused if I merge this if with the one above