Differential D14695

[lib] Provide a parent thread to notif creation code
ClosedPublic
Actions

Authored by tomek on May 13 2025, 12:58 PM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

kamil
angelika

Commits

rCOMM708b773268b8: [lib] Provide a parent thread to notif creation code

Summary

When creating a sidebar, we're sending notifs that sometimes need to know the parent thread info.

https://linear.app/comm/issue/ENG-10752/creating-a-sidebar-from-a-text-message-mentioning-a-user-fails

Test Plan

Created a sidebar from a message of another member and checked if the message creation succeeded.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.May 13 2025, 12:58 PM

Herald added a subscriber: ashoat. · View Herald TranscriptMay 13 2025, 12:58 PM

Harbormaster completed remote builds in B34163: Diff 48069.May 13 2025, 1:20 PM

tomek requested review of this revision.May 13 2025, 1:20 PM

kamil accepted this revision.May 13 2025, 4:36 PM

This revision is now accepted and ready to land.May 13 2025, 4:36 PM

Closed by commit rCOMM708b773268b8: [lib] Provide a parent thread to notif creation code. · Explain WhyMay 14 2025, 10:15 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM708b773268b8: [lib] Provide a parent thread to notif creation code.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

create-sidebar-spec.js

1 line

Diff 48076

lib/shared/dm-ops/create-sidebar-spec.js

Loading...