Differential D14761

[backup-client] Fix unnecessary user data cloning
ClosedPublic
Actions

Authored by bartek on May 26 2025, 10:28 AM.

Details

Reviewers

kamil

Commits

rCOMM5ac69684cc00: [backup-client] Fix unnecessary user data cloning

Summary

Address ENG-10524
We were unnecessarily cloning the whole items, replaced this with a reference

Test Plan

Build native, created a backup and performed a restore

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 26 2025, 10:28 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 26 2025, 10:28 AM

Harbormaster failed remote builds in B34263: Diff 48227!May 26 2025, 10:45 AM

Rebase

Harbormaster completed remote builds in B34266: Diff 48230.May 26 2025, 12:22 PM

bartek published this revision for review.May 26 2025, 12:33 PM

kamil accepted this revision.May 26 2025, 12:37 PM

This revision is now accepted and ready to land.May 26 2025, 12:37 PM

Closed by commit rCOMM5ac69684cc00: [backup-client] Fix unnecessary user data cloning. · Explain WhyMay 26 2025, 2:09 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5ac69684cc00: [backup-client] Fix unnecessary user data cloning.

Revision Contents
Changeset List

Path

Size

shared/

backup_client/

src/

lib.rs

2 lines

Diff 48263

View Options

shared/backup_client/src/lib.rs

[backup-client] Fix unnecessary user data cloningClosedPublicActions