Differential D14794

[native] Fix restore API call order
ClosedPublic
Actions

Authored by bartek on May 31 2025, 8:14 AM.

Details

Reviewers

kamil

Commits

rCOMMd272f07869bc: [native] Fix restore API call order

Summary

Noticed that in D14752 the order of the calls was correct in one file but wrong in the other. This resulted in

LOG  Error when restoring User Data: restoredConnectionManager is not set

Test Plan

The error no longer happens and after restoring (primary login) I'm able to see restored content (e.g. drafts)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 31 2025, 8:14 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 31 2025, 8:14 AM

bartek published this revision for review.May 31 2025, 8:15 AM

Harbormaster completed remote builds in B34331: Diff 48354.May 31 2025, 8:35 AM

There must've been some rebase issue because I was testing it, but I found this issue too in https://phab.comm.dev/D14790#inline-81176 - we can land this diff or mine Today, up to you

This revision is now accepted and ready to land.Jun 2 2025, 7:20 AM

bartek mentioned this in D14790: [lib][web] extract restoring user data to hook.Jun 2 2025, 9:10 AM

Closed by commit rCOMMd272f07869bc: [native] Fix restore API call order. · Explain WhyJun 2 2025, 9:54 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMd272f07869bc: [native] Fix restore API call order.

Revision Contents
Changeset List

Path

Size

native/

account/

restore.js

2 lines

Diff 48363

View Options

[native] Fix restore API call orderClosedPublicActions